Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup some compiler clients #13235

Merged

Conversation

privat
Copy link
Contributor

@privat privat commented Mar 31, 2023

Pharo11 and (current) Pharo12 and probably older versions of Pharo offers a failBlock on OpalCompiler.
But it is required if there is a requestor, and ignored otherwise.
So a failBlock without a requestor (or in faulty mode) is just dead code that can be removed.

This PR do some cleanup to remove unused failBlock (possible cruft).

It also removes the requestor of Monticello MethodAddition that is always nil

@privat privat changed the base branch from Pharo12 to Pharo11 March 31, 2023 18:49
@privat privat changed the base branch from Pharo11 to Pharo12 March 31, 2023 18:50
@privat privat changed the base branch from Pharo12 to Pharo11 March 31, 2023 20:04
@privat privat changed the base branch from Pharo11 to Pharo12 March 31, 2023 20:04
@privat privat force-pushed the cleanup-some-compiler-clients branch from 2429f6a to fc03573 Compare March 31, 2023 22:19
@privat privat changed the base branch from Pharo12 to Pharo11 March 31, 2023 23:29
@privat privat changed the base branch from Pharo11 to Pharo12 March 31, 2023 23:29
@MarcusDenker MarcusDenker merged commit bd3ea50 into pharo-project:Pharo12 Apr 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants