Use date and time as Stdio windows file name distinguisher #13299
Conversation
Stdio on windows will sometimes create a new file and since we can have multiple ones, we were generating a random number in the file name. Since the is the only dependency to Random-Core and that I would like to extract it from the KernelGroup of the bootstrap, I propose to use a timestamp instead. I also added a test to be sure the dependency does not get added again. One last change is the update of the manually resolved dependencies of Files package
|
|
||
| | dependencies | | ||
| dependencies := self externalDependendiesOf: #( 'Files' ). | ||
| self deny: (dependencies includes: 'Random-Core') |
There was a problem hiding this comment.
This feels weird. If you care about random things not being pulled. Why not just list the dependencies you want instead of blacklisting some that you do not want?
There was a problem hiding this comment.
That is something that I would like to do later but it requires to check the current dependencies of Files and think about which ones make sense or not and for now I just wanted to focus the extraction of Random-Core from the bootstrap core
There was a problem hiding this comment.
Some things seems simple, but then I end up spending hours in simple things and not finishing my original fix x_x
|
cyril can we use the nextFileNamed utils in filereference? Because like that it numbers the file automatically |
|
I am not sure we have a file reference of the previous stdio here so I went with the time stamp. But I don’t think it will cause too much trouble to the user because this is a hack anyway happening only on Windows when PharoConsole.exe is not used. And people will even be able to find easily the most recent one since it uses a file compatible timestamps |
Stdio on windows will sometimes create a new file and since we can have multiple ones, we were generating a random number in the file name. Since the is the only dependency to Random-Core and that I would like to extract it from the KernelGroup of the bootstrap, I propose to use a timestamp instead.
I also added a test to be sure the dependency does not get added again. One last change is the update of the manually resolved dependencies of Files package