Clean info of MethodChangeRecord #13519
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MethodChangeRecord saves an #info variable that contains first the last source pointer and the protocol of a removed method. The protocol is never used so I propose to remove it and transform this ugly array (why? why? why an array?!) into a variable storing the last source pointer. I have the impression that the changes source code can be improved further but that will be for another time (or maybe it will be removed before)
|
I think MethodChangeRecord used to be the model that the changesorter used. And then this was hacked in, I guess. Now we use Ring for modeling historical code, so this is not needed anymore |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MethodChangeRecord saves an #info variable that contains first the last source pointer and the protocol of a removed method. The protocol is never used so I propose to remove it and transform this ugly array (why? why? why an array?!) into a variable storing the last source pointer.
I have the impression that the changes source code can be improved further but that will be for another time (or maybe it will be removed before)