Scope: generalize target class #13540
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tead of `self compilationContext getClass`
…ationContext getClass`
jecisc
added
Status: Reviewed and Ready to Integrate
and removed
Status: Tests passed please review!
labels
MarcusDenker
approved these changes
Apr 25, 2023
|
yes, I think it is ok |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For the semantic analysis, scopes are nested objects, so demanding a variable binding is either answer or delegated to an outer scope.
Except for
targetClassandtargetEnvironmentthat were only available at a single scope level (the weirdly named SemanticScope).So this PR push up
targetClassandtargetEnvironement(renamed as environment) so all scope can access it, and update some clients.Especially, it updates
RBMetodNode>>methodClassto simply rely on its scope instead of asking compilationContext.The side effect is that
RBMetodNode scopemust be setup earlier in the semantic analysis, as some plugin examples expect it.This feel like a good move, but I'm willing to consider alternatives if someone have a better idea.