Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run coverage button is enabled with unselected packages ( Dr Tests ) #13836

Merged
merged 1 commit into from
May 27, 2023

Conversation

CarolinaMelendez
Copy link
Contributor

#13806
This PR contains a modification to prevent the exception of "collect was sent to nil"

@welcome
Copy link

welcome bot commented May 26, 2023

Thanks for opening this pull request! Now continious integration (CI) will build Pharo with your change and run all tests. This might fail due to many reasons! Please check if your PR breaks the build or makes tests fail. Feel free to add comments to the PR. After this, before your PR can be merged it needs one or more reviews. Do not hesitate to ask people (on the Mailinglist or Discord) to help! When the CI shows no problems and there are positive reviews, your PR will be merged.

@Ducasse
Copy link
Member

Ducasse commented May 27, 2023

Thanks for the contribution. It would be great to have a test covering this bug.

@Ducasse Ducasse changed the title bugfix Run coverage button is enabled with unselected packages ( Dr Tests ) May 27, 2023
@Ducasse
Copy link
Member

Ducasse commented May 27, 2023

failing test is unrelated

@Ducasse Ducasse merged commit 37087ca into pharo-project:Pharo12 May 27, 2023
@welcome
Copy link

welcome bot commented May 27, 2023

Congrats on merging your first pull request! Do another one! We try to have a list of (relatively) easy issues here: https://github.com/orgs/pharo-project/projects/8.

GitHub
GitHub is where people build software. More than 100 million people use GitHub to discover, fork, and contribute to over 330 million projects.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants