21932-Cleanup-in-Athens-Examples #1387
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DraagrenKirneh
suggested changes
May 19, 2018
| @@ -14,6 +14,12 @@ Class { | |||
| #category : #'Athens-Examples-Demos' | |||
| } | |||
|
|
|||
| { #category : #'instance creation' } | |||
| AthensFlakeDemo class >> open [ | |||
| <script> | |||
There was a problem hiding this comment.
The example pragma is a better fit when something is actually opened, not just run as a script
| @@ -4,9 +4,6 @@ An example from a workshop | |||
| Class { | |||
There was a problem hiding this comment.
This class is not referenced anywhere and do not provide a way to see the example showcase. we should either just remove it, provide an open method, or move the example (#drawQuadFrom:via:to:on: canvas) into AthensDemoMorph.
This is what the CurveWorkshop shows
| surface canvas |
surface := AthensCairoSurface extent: 200@200.
canvas := surface newCanvas.
CurveWorkshop new drawOn: canvas.
surface asForm asMorph openInWindow- remove CurveWorkshop
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cleanup in Athens Examples
https://pharo.fogbugz.com/f/cases/21932/Cleanup-in-Athens-Examples