Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

21932-Cleanup-in-Athens-Examples #1387

Merged
merged 2 commits into from May 19, 2018
Merged

21932-Cleanup-in-Athens-Examples #1387

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c720998
Cleanup in Athens Examples
MarcusDenker May 19, 2018
cc726c6
- example instead of script tag
MarcusDenker May 19, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 0 additions & 3 deletions src/Athens-Examples/AthensDemoMorph.class.st
View file
Open in desktop
Expand Up @@ -11,10 +11,7 @@ Class {
#superclass : #Morph,
#instVars : [
'surface',
'animations',
'current',
'zooming',
'scale',
'frame',
'pharoLogo',
'esugBallon'
Expand Down
6 changes: 6 additions & 0 deletions src/Athens-Examples/AthensFlakeDemo.class.st
View file
Open in desktop
Expand Up @@ -14,6 +14,12 @@ Class {
#category : #'Athens-Examples-Demos'
}

{ #category : #'instance creation' }
AthensFlakeDemo class >> open [
<script>
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The example pragma is a better fit when something is actually opened, not just run as a script

self new openInWindow
]

{ #category : #accessing }
AthensFlakeDemo >> circle [
^ circle
Expand Down
1 change: 0 additions & 1 deletion src/Athens-Examples/AthensSimpleTreeNode.class.st
View file
Open in desktop
Expand Up @@ -10,7 +10,6 @@ Class {
'subject',
'extent',
'layoutWidth',
'childsHeight',
'originX',
'originY',
'color'
Expand Down
21 changes: 20 additions & 1 deletion src/Athens-Examples/AthensTigerShape.class.st
View file
Open in desktop
Expand Up @@ -5,7 +5,6 @@ Class {
#name : #AthensTigerShape,
#superclass : #Object,
#instVars : [
'paint',
'path',
'fillRule',
'fill',
Expand All @@ -30,6 +29,11 @@ AthensTigerShape >> addStroke [
stroke := true.
]

{ #category : #accessing }
AthensTigerShape >> capStyle [
^capStyle
]

{ #category : #accessing }
AthensTigerShape >> capStyle: cap [
capStyle := cap.
Expand All @@ -55,11 +59,21 @@ AthensTigerShape >> initialize [
fill := stroke := false.
]

{ #category : #accessing }
AthensTigerShape >> joinStyle [
^joinStyle
]

{ #category : #accessing }
AthensTigerShape >> joinStyle: join [
joinStyle := join.
]

{ #category : #accessing }
AthensTigerShape >> miterLimit [
^miterLimit
]

{ #category : #accessing }
AthensTigerShape >> miterLimit: lim [
miterLimit := lim.
Expand Down Expand Up @@ -103,6 +117,11 @@ AthensTigerShape >> strokePaint: aColor [
strokePaint := aColor
]

{ #category : #accessing }
AthensTigerShape >> strokeWidth [
^strokeWidth
]

{ #category : #accessing }
AthensTigerShape >> strokeWidth: w [
strokeWidth := w
Expand Down
3 changes: 0 additions & 3 deletions src/Athens-Examples/CurveWorkshop.class.st
View file
Open in desktop
Expand Up @@ -4,9 +4,6 @@ An example from a workshop
Class {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This class is not referenced anywhere and do not provide a way to see the example showcase. we should either just remove it, provide an open method, or move the example (#drawQuadFrom:via:to:on: canvas) into AthensDemoMorph.

This is what the CurveWorkshop shows

| surface canvas |

surface := AthensCairoSurface extent: 200@200.
canvas := surface newCanvas.

CurveWorkshop new drawOn: canvas.

surface asForm asMorph openInWindow

#name : #CurveWorkshop,
#superclass : #Object,
#instVars : [
'surface'
],
#category : #'Athens-Examples-Workshop'
}

Expand Down