22843-Cannot-select-all-in-windows #2157
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…his OS returns keyCharacters as uppercase
estebanlm
reviewed
Jan 2, 2019
| ifFalse: [ self keyCharacter ] | ||
| self flag: #hack. | ||
| "Hack me. When Ctrl is pressed, the key ascii value is not right and we have to do something ugly" | ||
| ^(self hasSpecialCTRLKeyValue and: [ (#(MacOSX Windows) includes: Smalltalk os current platformFamily) ]) |
There was a problem hiding this comment.
Smalltalk os platformFamily is enough here. Why the "current" ?
There was a problem hiding this comment.
meh, I see it was like that before.
still no need :)
There was a problem hiding this comment.
@estebanlm I don't know if you know, but now you can suggest one line changes in reviews to make it easier to contribute.
You can use this icon.
jecisc
requested changes
Jan 4, 2019
|
Except the little cleanup requested, the PR works for me on Windows 7. |
Co-Authored-By: pavel-krivanek <pavel.krivanek@gmail.com>
jecisc
approved these changes
Jan 4, 2019
|
Test failure not related. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
do an image patch for Windows VM inconsistency with other platforms. This OS returns keyCharacters as uppercase