2466-Remove-unused-variables #2468
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes pharo-project#2466 For now it does not fix everything but it's a first step
|
I cannot commit class instance var removal because of pharo-vcs/iceberg#1168 :( |
|
I think I did not removed variables used for tests but I am not 100% sure. I'll wait the checks to verify. |
jecisc
changed the title
|
Some broken tests are related. I'll fix them next week. |
|
failing tests now seem to be the ones that fail always (not related to the change) |
|
this was not in "ignore" status? :P |
|
I corrected the tests failures so it was integrable. I just forgot to remove the ignore. |
jecisc
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove unused instance variables.
Fixes #2466
For now it does not fix everything but it's a first step