Adding flags for Smalltalk reference. Refactor some direct reference … #3155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jecisc
requested changes
Apr 10, 2019
|
Ok thanks jecisc, i am going to change that. |
jecisc
reviewed
Apr 10, 2019
jecisc
reviewed
Apr 10, 2019
|
@jecisc can you check that the new changes are ok? |
jecisc
reviewed
Apr 10, 2019
| @@ -18,6 +18,7 @@ Class { | |||
|
|
|||
| { #category : #private } | |||
| NECVarTypeGuesser class >> classFrom: className [ | |||
|
|
|||
There was a problem hiding this comment.
I was planning on removing this one but forgot about it in the end. It needs to be pushed in the instance side.
|
Please do not remove that without adding a hook to get the same behavior if you work on it :( It must be horrible to code in Seaside if the code completion propose methods that are not from the canvas in rendering methods :'( |
tesonep
requested changes
Apr 11, 2019
guillep
approved these changes
Apr 12, 2019
tesonep
approved these changes
Apr 12, 2019
|
Thanks Theo! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…to instVar.
NECCompletion had a lot of them and it could be nice to be able to pass another Environment as argument.