Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "2568-copyUpTo-and-copyUpThrough-are-identical-in-SequencableCollection" #3473

Merged
merged 1 commit into from
Jun 10, 2019
Merged

Revert "2568-copyUpTo-and-copyUpThrough-are-identical-in-SequencableCollection" #3473

merged 1 commit into from
Jun 10, 2019

Conversation

tesonep
Copy link
Collaborator

@tesonep tesonep commented Jun 7, 2019

Reverts #3453

@MarcusDenker
Copy link
Member

why?

@tesonep
Copy link
Collaborator Author

tesonep commented Jun 7, 2019

#3472
The original change was wrong, the methods are doing the same. In one is returning an element more in the collection.

copyUpTo: anElement
"Answer all elements up to but not including anObject. If there
is no such object, answer a copy of the receiver."

copyUpThrough: anElement
"Answer all elements up to and including anObject. If there
is no such object, answer a copy of the receiver."

@tesonep tesonep merged commit 1aae0c7 into Pharo8.0 Jun 10, 2019
@tesonep tesonep deleted the revert-3453-2568-copyUpTo-and-copyUpThrough-are-identical-in-SequencableCollection branch June 10, 2019 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tesonep @MarcusDenker