Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Backport] Fix for #3410-[Trait] Impossible to use from a classTrait a method that is also defined in a subclass of Behavior even when following the doc #3906

Merged
merged 2 commits into from
Jul 19, 2019
Merged

[Backport] Fix for #3410-[Trait] Impossible to use from a classTrait a method that is also defined in a subclass of Behavior even when following the doc #3906

merged 2 commits into from
Jul 19, 2019

Conversation

VincentBlondeau
Copy link
Contributor

add tests for issue
Fix previous failing test

@VincentBlondeau
Solve partially the issue pharo-project#3410
30d0561 
add tests for issue
Fix previous failing test
@VincentBlondeau
Copy link
Contributor Author

#3410

@MarcusDenker
Copy link
Member

one failing test seems related:

Error
Subclasses of TestCase should have #tearDown methods in category running
Stacktrace
ProperMethodCategorizationTest(TestAsserter)>>assert:description:
ProperMethodCategorizationTest>>assureAll:areCategorizedIn:whenSubclassOf:
ProperMethodCategorizationTest>>testTearDownMethodInSUnitTestsNeedsToBeInRunningProtocol

@VincentBlondeau VincentBlondeau changed the title [Backport] Fix for #3410 [Backport] Fix for #3410-[Trait] Impossible to use from a classTrait a method that is also defined in a subclass of Behavior even when following the doc Jul 15, 2019
@VincentBlondeau
Copy link
Contributor Author

Fixed

@VincentBlondeau VincentBlondeau mentioned this pull request Jul 17, 2019
Closed
@MarcusDenker
Copy link
Member

The Pharo 8 change has been merged. We should wait some days to see if there are any bad side effects, if not we can merge this

@MarcusDenker
Copy link
Member

We used it for some days: no problem.

@MarcusDenker MarcusDenker merged commit b8c5878 into pharo-project:Pharo7.0 Jul 19, 2019
@VincentBlondeau
Copy link
Contributor Author

Thanks Marcus!

@VincentBlondeau VincentBlondeau deleted the FIX/Backportof#3410 branch July 19, 2019 08:13
@weekly-digest weekly-digest bot mentioned this pull request Jul 21, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarcusDenker MarcusDenker MarcusDenker approved these changes

@tesonep tesonep Awaiting requested review from tesonep

Assignees
No one assigned
Labels
Status: Tests passed please review!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@VincentBlondeau @MarcusDenker