Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport] Fix for #3410-[Trait] Impossible to use from a classTrait a method that is also defined in a subclass of Behavior even when following the doc #3906

Merged

Conversation

@VincentBlondeau
Copy link
Contributor

commented Jul 12, 2019

add tests for issue
Fix previous failing test

VB
Solve partially the issue #3410
add tests for issue
Fix previous failing test
@VincentBlondeau

This comment has been minimized.

Copy link
Contributor Author

commented Jul 12, 2019

@MarcusDenker

This comment has been minimized.

Copy link
Member

commented Jul 15, 2019

one failing test seems related:

Error
Subclasses of TestCase should have #tearDown methods in category running
Stacktrace
ProperMethodCategorizationTest(TestAsserter)>>assert:description:
ProperMethodCategorizationTest>>assureAll:areCategorizedIn:whenSubclassOf:
ProperMethodCategorizationTest>>testTearDownMethodInSUnitTestsNeedsToBeInRunningProtocol

@VincentBlondeau VincentBlondeau changed the title [Backport] Fix for #3410 [Backport] Fix for #3410-[Trait] Impossible to use from a classTrait a method that is also defined in a subclass of Behavior even when following the doc Jul 15, 2019

@VincentBlondeau

This comment has been minimized.

Copy link
Contributor Author

commented Jul 15, 2019

Fixed

@MarcusDenker

This comment has been minimized.

Copy link
Member

commented Jul 17, 2019

The Pharo 8 change has been merged. We should wait some days to see if there are any bad side effects, if not we can merge this

@MarcusDenker

This comment has been minimized.

Copy link
Member

commented Jul 19, 2019

We used it for some days: no problem.

@MarcusDenker MarcusDenker merged commit b8c5878 into pharo-project:Pharo7.0 Jul 19, 2019

2 of 3 checks passed

continuous-integration/jenkins/pr-merge This commit cannot be built
Details
WIP Ready for review
Details
probot/minimum-reviews No pending reviews
@VincentBlondeau

This comment has been minimized.

Copy link
Contributor Author

commented Jul 19, 2019

Thanks Marcus!

@VincentBlondeau VincentBlondeau deleted the VincentBlondeau:FIX/Backportof#3410 branch Jul 19, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.