Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #2853. When removing a class, also log its contained methods #4832

Conversation

@tinchodias
Copy link
Contributor

tinchodias commented Oct 4, 2019

I propose this fix/workaround to tackle this issue.

@tinchodias

This comment has been minimized.

Copy link
Contributor Author

tinchodias commented Oct 4, 2019

Included a test, but you can also evaluate this code and see the result in the Code Changes browser:

clazz := Object subclass: #Clazz
	instanceVariableNames: ''
	classVariableNames: ''
	poolDictionaries: ''
	package: 'Martin'.

1 to: 7 do: [:index |
	clazz compile: 'inst', index asString.
	clazz classSide compile: 'class', index asString ].
clazz removeFromSystem.
@tinchodias

This comment has been minimized.

Copy link
Contributor Author

tinchodias commented Oct 4, 2019

Epicea supports nesting events (e.g. in refactorings), so it could be an improvement to this fix to nest al method removals inside the class removal. This can be reported as another issue.

@MarcusDenker MarcusDenker merged commit baa0eac into pharo-project:Pharo8.0 Oct 11, 2019
1 of 3 checks passed
1 of 3 checks passed
continuous-integration/jenkins/pr-merge This commit cannot be built
Details
probot/minimum-reviews Pending review approvals
WIP Ready for review
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.