Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix-protocol-and-remove-useless-method #5055

Merged
merged 2 commits into from
Nov 6, 2019
Merged

Fix-protocol-and-remove-useless-method #5055

merged 2 commits into from
Nov 6, 2019

Conversation

jecisc
Copy link
Member

@jecisc jecisc commented Nov 5, 2019

Fix protocol of Behavior>>#instSize and remove useless check that Object has no instance variables.

MarcusDenker
MarcusDenker approved these changes Nov 6, 2019
View reviewed changes
Copy link
Member

@MarcusDenker MarcusDenker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I checked all implementors of veryDeepCopyWith: and none relies on ivar offsets

@MarcusDenker MarcusDenker merged commit b765ed0 into pharo-project:Pharo8.0 Nov 6, 2019
@jecisc jecisc deleted the Fix-protocol-and-remove-useless-method branch November 29, 2022 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarcusDenker MarcusDenker MarcusDenker approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jecisc @MarcusDenker