Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

5232-Remove-GTEventRecorder- #5236

Merged
merged 2 commits into from
Nov 26, 2019
Merged

5232-Remove-GTEventRecorder- #5236

merged 2 commits into from
Nov 26, 2019

Conversation

Ducasse
Copy link
Member

@Ducasse Ducasse commented Nov 26, 2019

Fixes: #5232

@Ducasse Ducasse closed this Nov 26, 2019
@Ducasse Ducasse reopened this Nov 26, 2019
@Ducasse Ducasse closed this Nov 26, 2019
@Ducasse Ducasse reopened this Nov 26, 2019
@Ducasse
Copy link
Member Author

Ducasse commented Nov 26, 2019

May be this is this extra reference that caused problem.

@Ducasse
Copy link
Member Author

Ducasse commented Nov 26, 2019

Always the dependencies tests that are broken.
I started to check to understand them but they look bad. So I will see if I succeed to fix them.

@Ducasse Ducasse merged commit 7e5cb5c into pharo-project:Pharo8.0 Nov 26, 2019
@pavel-krivanek
Copy link
Collaborator

I was not a good decision to merge this PR.

  • The spotter is not working now
  • SystemDependenciesTest>>#testExternalIDEDependencies has error (BaselineOfBlueInk reference needs to be removed), I'm not sure if this PR did it
  • SystemDependenciesTest>>#testExternalUIDependencies is failing, AST-Core-Tests need to be removed from SystemDependenciesTest>>#knownUIDependencies
  • SystemDependenciesTest>>#testExternalBasicToolsDependencies is failing, AST-Core-Tests need to be removed from SystemDependenciesTest>>#knownBasicToolsDependencies

@pavel-krivanek pavel-krivanek mentioned this pull request Nov 26, 2019
Merged
jecisc pushed a commit to jecisc/pharo that referenced this pull request Nov 28, 2019
@Ducasse @jecisc
Revert "Merge pull request pharo-project#5236 from Ducasse/5232-Remov…
89ad8f5 
…e-GTEventRecorder-"

This reverts commit 7e5cb5c.
@Ducasse Ducasse deleted the 5232-Remove-GTEventRecorder- branch July 13, 2020 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove GTEventRecorder.
2 participants
@Ducasse @pavel-krivanek