Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

4454-TraitedMetaClassisRejectedMethod-rejects-too-many-methods #5283

Merged
merged 2 commits into from Dec 3, 2019
Merged

4454-TraitedMetaClassisRejectedMethod-rejects-too-many-methods #5283

merged 2 commits into from Dec 3, 2019

Conversation

MarcusDenker
Copy link
Member

  • change #isRejectedMethod: to never reject methods that are in the trait composition
  • inline the comments into the code (easier to understand)

Traits tests are green

fixes #4454 (I hope)

@MarcusDenker
- change #isRejectedMethod: to never reject methods that are in the t…
e7539b5 
…rait composition

- inline the comments into the code (easier to understand)

Traits tests are green

fixes pharo-project#4454 (I hope)
@MarcusDenker MarcusDenker mentioned this pull request Dec 2, 2019
Closed
VincentBlondeau
VincentBlondeau suggested changes Dec 2, 2019
View reviewed changes
Copy link
Contributor

@VincentBlondeau VincentBlondeau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we add a test in a subclass of T2AbstractTest so we are sure that the bug we will raise again?
Thanks!

@MarcusDenker
Copy link
Member Author

yes! we should really add a test for this

VincentBlondeau
VincentBlondeau approved these changes Dec 2, 2019
View reviewed changes
Copy link
Contributor

@VincentBlondeau VincentBlondeau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Marcus!

@MarcusDenker
Copy link
Member Author

all tests green

@MarcusDenker MarcusDenker merged commit b0b96fb into pharo-project:Pharo8.0 Dec 3, 2019
@MarcusDenker MarcusDenker mentioned this pull request Dec 4, 2019
Closed
@kasperosterbye kasperosterbye mentioned this pull request Jan 31, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VincentBlondeau VincentBlondeau VincentBlondeau approved these changes

@tesonep tesonep Awaiting requested review from tesonep

Assignees
No one assigned
Labels
Status: Tests passed please review!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

TraitedMetaClass>>isRejectedMethod: rejects too many methods
2 participants
@MarcusDenker @VincentBlondeau