Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TraitedMetaClass>>isRejectedMethod: rejects too many methods #4454

Closed
theseion opened this issue Aug 31, 2019 · 2 comments · Fixed by #5283
Closed

TraitedMetaClass>>isRejectedMethod: rejects too many methods #4454

theseion opened this issue Aug 31, 2019 · 2 comments · Fixed by #5283
Assignees
@tesonep
Projects
Traits

Comments

@theseion
Copy link
Contributor

I need to override two methods on the class side: #ffiLibrary and ffiLibraryName. I do this with a trait. When I compile the class I lose those two overrides due to the logic in TraitedMetaClass>>isRejectedMethod:.
@Ducasse Ducasse assigned Ducasse and tesonep and unassigned tesonep and Ducasse Aug 31, 2019
@theseion
Copy link
Contributor Author

Note that there appears to be a separate issue with Calypso. In my case I hacked #isRejectedMethod to install those methods but they don't show up in Calypso. I can send the messages and they answer the expected values though.

@weekly-digest weekly-digest bot mentioned this issue Sep 4, 2019
Closed
@MarcusDenker MarcusDenker added this to To do in Traits Nov 8, 2019
@MarcusDenker MarcusDenker mentioned this issue Nov 29, 2019
Closed
MarcusDenker added a commit to MarcusDenker/pharo that referenced this issue Dec 2, 2019
@MarcusDenker
- change #isRejectedMethod: to never reject methods that are in the t…
e7539b5 
…rait composition

- inline the comments into the code (easier to understand)

Traits tests are green

fixes pharo-project#4454 (I hope)
@MarcusDenker MarcusDenker mentioned this issue Dec 2, 2019
Merged
Traits automation moved this from To do to Done Dec 3, 2019
@theseion
Copy link
Contributor Author

theseion commented Dec 3, 2019

Thanks Marcus!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tesonep tesonep

Labels
None yet
Projects
Traits
  
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

4454-TraitedMetaClassisRejectedMethod-rejects-too-many-methods MarcusDenker/pharo
3 participants
@theseion @tesonep @Ducasse