[improvement] now returns a selfNode directly rather than wait for th… #5460
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Forgot that I had this PR open. should have done a different one, but it's small enough to pass anyway. @MarcusDenker I don't know if anExpression is the best name as replacement (see second commit), But I think aValueNode is missleading for people trying to learn the API |
MarcusDenker
approved these changes
Jan 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…e semantic analysis
follow up of #5459
Edit: Also renamed RBReturnNode >> value: aValueNode argument to anExpression.
(for future research)
might need to move to P9, i don't have anything ready for a quick fix on this, sorry >_<