Revert "5724-Improve-AdditionalMethodStaterefersToLiteral" #5770
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Would be nice to have tests to enforce the desired semantics, which seem odd to me...
… El 26 feb 2020, a las 15:54, Marcus Denker ***@***.***> escribió:
Reverts #5731 <#5731>
This was not a good change: semantics are a bit odd: for Bindings, we want to only look into them deeply if they are in a property. Else not. I will revert it and put a comment.
(it does not add a bug this way but it is even more confusing as before)
You can view, comment on, or merge this pull request online at:
#5770 <#5770>
Commit Summary
Revert "5724-Improve-AdditionalMethodStaterefersToLiteral"
File Changes
M src/Collections-Support/LookupKey.class.st <https://github.com/pharo-project/pharo/pull/5770/files#diff-0> (7)
M src/Kernel/AdditionalMethodState.class.st <https://github.com/pharo-project/pharo/pull/5770/files#diff-1> (13)
Patch Links:
https://github.com/pharo-project/pharo/pull/5770.patch <https://github.com/pharo-project/pharo/pull/5770.patch>
https://github.com/pharo-project/pharo/pull/5770.diff <https://github.com/pharo-project/pharo/pull/5770.diff>
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub <#5770?email_source=notifications&email_token=AAFM5YUSUAVVHWU6WDOMJRTREZ7EDA5CNFSM4K4HKYLKYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4IQPRERA>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAFM5YSKTB4WOPUUBCTZ7VDREZ7EDANCNFSM4K4HKYLA>.
|
|
I found that odd, too. There are tests (for the properties case). This is how I found it. I thought "no, that code is wrong, we never want to look at a value of a VariableBinding for the literals" --> boom, test that checks for it fails. |
|
I will out this on "need more work" as I am tempted to get rid of the strange semantics... we should not look into globals if the are the the value of a method property! |
MarcusDenker
added
the
Status: Need more work
|
So this PR gets rid of a bug? If so, It has my approval. |
guillep
approved these changes
Mar 14, 2020
guillep
added
Status: Reviewed and Ready to Integrate
Status: Tests passed please review!
and removed
Status: Need more work
|
I could integrate it, I just need confirmation from @MarcusDenker |
|
yes, we should merge this revert |
|
Thanks Marcus! |
guillep
deleted the
revert-5731-5724-Improve-AdditionalMethodStaterefersToLiteral
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #5731
This was not a good change: semantics are a bit odd: for Bindings, we want to only look into them deeply if they are in a property. Else not. I will revert it and put a comment.
(it does not add a bug this way but it is even more confusing as before)