Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

4456 layout frame should be friendly to possible migration #5812

Conversation

DanAparicio22
Copy link

Implement a new method to fix #4456

@welcome
Copy link

welcome bot commented Feb 28, 2020

Thanks for opening this pull request! Now continious integration (CI) will build Pharo with your change and run all tests. This might fail due to many reasons! Please check if your PR breaks the build or makes tests fail. Feel free to add comments to the PR. After this, before your PR can be merged it needs one or more reviews. Do not hesitate to ask people (on the Mailinglist or Discord) to help! When the CI shows no problems and there are positive reviews, your PR will be merged.

@Ducasse
Copy link
Member

Ducasse commented Feb 28, 2020

The proposed code can be a first step.
Now can you use cr instead of nextPut: String cr?

@DanAparicio22
Copy link
Author

Sure, I work on it

@guillep
Copy link
Member

guillep commented Mar 14, 2020

There is some problem with the dependencies it seems, the build is not green :(.
I'll relaunch the CI. If the problem persist I'll check the tests locally and fix them in a separate PR.

@Ducasse can you confirm that the issues you marked have been correctly addressed? ^^

@Ducasse Ducasse merged commit 63c83df into pharo-project:Pharo9.0 Mar 27, 2020
@welcome
Copy link

welcome bot commented Mar 27, 2020

Congrats on merging your first pull request! Do another one! We try to have a list of (relatively) easy issues here: https://github.com/orgs/pharo-project/projects/8.

GitHub
GitHub is where people build software. More than 40 million people use GitHub to discover, fork, and contribute to over 100 million projects.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

printOn: of LayoutFrame should be friendly to possible migration
4 participants