Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix 6160 Cleanup two tests in BlockClosureTest #6178

Merged
merged 1 commit into from
Apr 14, 2020
Merged

Fix 6160 Cleanup two tests in BlockClosureTest #6178

merged 1 commit into from
Apr 14, 2020

Conversation

VincentBlondeau
Copy link
Contributor

@VincentBlondeau VincentBlondeau commented Apr 14, 2020 •
edited
Loading

Fix #6160

@request-info
Copy link

request-info bot commented Apr 14, 2020

This issue has either a default title or empty body. We would appreciate it if you could provide more information. Note: I am not a very intelligent bot, I can only react to new comments. Please add a comment for me if you update the body or title.

@request-info request-info bot added the Status: more-information-needed This issue will be auto-closed if no answer in 14 days label Apr 14, 2020
@VincentBlondeau
Copy link
Contributor Author

Indeed, you are not a very intelligent bot :)

astares
astares approved these changes Apr 14, 2020
View reviewed changes
Copy link
Member

@astares astares left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK

@Ducasse
Copy link
Member

Ducasse commented Apr 14, 2020

Thanks vincent.
What would be nice is it package the supply method with the UImanager or in a separate package. I super tired but I found super strange to have a dependency to the UIManager from the BlockClosure tests. We can do that in another issue.

@Ducasse Ducasse merged commit c0025ab into pharo-project:Pharo9.0 Apr 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@astares astares astares approved these changes

Assignees
No one assigned
Labels
Status: more-information-needed This issue will be auto-closed if no answer in 14 days
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cleanup two tests in BlockClosureTest
3 participants
@VincentBlondeau @Ducasse @astares