5193-Running-Executable-Comments-Checker-on-200-000-Classes-images-should-work-faster #6801
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pre-checking of the sourceCode of the method contains a string >>> This avoids to call #comments on the method which is very slow due to creating the AST. fixes pharo-project#5193 at least to some extent: It is now quite usable for the image, which means it should be *much* faster for a larger image.
dionisiydk
approved these changes
Jul 8, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This speeds up both selecting packages and then running the tests by pre-checking of the sourceCode of the method contains a string >>>
This avoids to call #comments on the method which is very slow due to creating the AST.
fixes #5193 at least to some extent: It is now quite usable for the image, which means it should be much faster for a larger image.