Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix some more doc comments #9246

Merged
merged 1 commit into from
May 4, 2021
Merged

Fix some more doc comments #9246

merged 1 commit into from
May 4, 2021

Conversation

MarcusDenker
Copy link
Member

  • Collection>>#unzip: fix formatting
  • SequenceableCollection>>#atWrap:put: , we can not compare an array with an OrderedCollection
  • Context>>#setNamedPrimitiveInformationFrom:toMethod: To me this is too low level for a doc comment
  • Point>>#sideOf: was just wrong

@MarcusDenker
Fix some more doc comments:
8bc2553 
- Collection>>#unzip: fix formatting
- SequenceableCollection>>#atWrap:put: , we can not compare an array with an OrderedCollection
- Context>>#setNamedPrimitiveInformationFrom:toMethod: To me this is too low level for a doc comment
- Point>>#sideOf: was just wrong
@Ducasse
Copy link
Member

Ducasse commented May 4, 2021

Marcus is the formatting breaking them? Because we could then use the Parser to avoid to get such brittleness.

@Ducasse Ducasse merged commit 40d366e into pharo-project:Pharo9.0 May 4, 2021
@MarcusDenker
Copy link
Member Author

Yes, somehow the current implementation expects everything in one line. You can see that already from how it is syntax highlighted. I will have a look...

@Ducasse
Copy link
Member

Ducasse commented May 6, 2021

This is probably a hack of the first version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Status: Tests passed please review!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MarcusDenker @Ducasse