Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix selection bug in SpFilteringSelectableListPresenter #1535

Merged
merged 2 commits into from
Apr 9, 2024
Merged

Fix selection bug in SpFilteringSelectableListPresenter #1535

merged 2 commits into from
Apr 9, 2024

Commits on Apr 9, 2024

  1. Fix selection bug in SpFilteringSelectableListPresenter 

    SpFilteringSelectableListPresenter has items and a list of the selected items. But if we change the items while a selection exists, we end up with selected elements that are not in the list. 

I propose to filter out those selected elements when we update the items. This fixes a bug in the ChooserPresenter when we could have duplicated elements in the target list if we clicked multiple times on the "move elements" button.
    @jecisc
    jecisc committed Apr 9, 2024
    Configuration menu
    Copy the full SHA
    7ad9c84 View commit details
    Browse the repository at this point in the history

  2. Reduce size of the change

    @jecisc
    jecisc committed Apr 9, 2024
    Configuration menu
    Copy the full SHA
    ddcd334 View commit details
    Browse the repository at this point in the history