-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adjusting outline-docs package so projects can use them #381
Conversation
Also changes the template for spinning up new projects
|
✅ Deploy Preview for outlinejs ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
…line-template version number
@@ -1,7 +1,7 @@ | |||
{ | |||
"name": "@phase2/outline-templates", | |||
"description": "The Outline Starter Templates", | |||
"version": "0.0.33", | |||
"version": "0.0.34", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should I be changing these or is this automatically managed on merging based on the conventional commit messages?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, because outline-templates
had content updated (the package.json
in the default
directory, this should be bumped an a new release created for the template.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I need to document (and automate) the Changeset releases to make this easier to understand.
For some reason this is failing at the moment as https://yarnpkg.com/package/@phase2/outline-templates is out of sync with https://www.npmjs.com/package/@phase2/outline-templates Going to merge and move on to see if this somehow clears up. A new release will need to be triggered with these updates anyway. |
Description
Modify the build to actually include the documentation files, correct README, and change the template for spinning up new projects to automatically include them in the storybook instance. This will result in the Documentation folder with welcome and guides one sees on https://outline.phase2tech.com/ to be present in the project's Storybook instance as well.
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Checklist