Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/comprehensive updates #385

Merged
merged 8 commits into from
May 22, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion .github/workflows/build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,6 @@ on:
- alpha
- beta
- rc
- feature/local-dev-dx
# Which branches to test on pull request.
pull_request:
branches:
Expand Down
2 changes: 1 addition & 1 deletion packages/outline-core/src/controllers/light-dom-styles.ts
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
/* eslint-disable no-console */
import { ReactiveControllerHost, CSSResultGroup, CSSResult } from 'lit';
import { addScopeToStyles } from '../internal/light-dom';
import { addScopeToStyles } from '../internal/light-dom.mjs';
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.


/**
* The LightComStyles ReactiveController.
Expand Down
6 changes: 6 additions & 0 deletions packages/outline-core/src/internal/light-dom.d.mts
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
/**
* Add the scopeId to each CSS rule selector.
* Handle the :host and ::slotted selectors.
*/
export function addScopeToStyles(cssStyles: string, scopeId: string): string;
//# sourceMappingURL=light-dom.d.mts.map
3 changes: 2 additions & 1 deletion packages/outline-core/tsconfig.build.json
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,8 @@
"extends": "../../tsconfig.json",
"compilerOptions": {
"rootDir": ".",
"outDir": "./dist"
"outDir": "./dist",
"allowJs": true
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

},
"include": ["index.ts", "src/**/*", "tests/**/*"]
}
1 change: 1 addition & 0 deletions packages/outline-templates/default/rollup.config.mjs
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,7 @@ const defaultOutput = {
'src/components/**/*.css.lit.ts',
'src/components/**/*.test.ts',
'src/components/examples/**/*',
'src/components/sample/**/*',
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

],
},
output: [
Expand Down
2 changes: 1 addition & 1 deletion packages/outline-templates/default/scripts/styles.mjs
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ import postcss from 'postcss';
import fs from 'fs';
import path from 'path';
import glob from 'glob';
import config from '@phase2/outline-config/postcss.config.js';
import config from '../postcss.config.js';
import outline from '../outline.config.js';
import { addScopeToStyles } from '@phase2/outline-core/src/internal/light-dom.mjs';

Expand Down
1 change: 1 addition & 0 deletions packages/outline-templates/default/tsconfig.json
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,7 @@
"exclude": [
"./src/components/**/*.stories.ts",
"./src/components/**/*.lit.ts",
"./src/components/sample/**/*",
himerus marked this conversation as resolved.
Show resolved Hide resolved
"node_modules"
]
}