Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #2320: properly size filter texture and viewport #2326

Merged
merged 2 commits into from
Feb 7, 2016

Conversation

englercj
Copy link
Contributor

@englercj englercj commented Feb 6, 2016

This patch is to fix the bugs brought up in #2320. It does so by properly sizing both the filter texture and the gl viewport.

@amadeus
Copy link

amadeus commented Feb 6, 2016

This is awesome and definitely getting closer. One issue I have found however, is that it ends up breaking down if you add more than 2 filters in a very interesting way. I have update the demo code to reflect this - if you click the Add Scene Filter button, it creates a super tiny, filtered image super imposed on top of the unfiltered image. - http://wtf.amadeus.wtf/phaser-filter-bug-demo/#4

@englercj
Copy link
Contributor Author

englercj commented Feb 7, 2016

Should be good now, I had missed the output texture location :P

photonstorm added a commit that referenced this pull request Feb 7, 2016
Fix #2320: properly size filter texture and viewport
@photonstorm photonstorm merged commit 1465d18 into phaserjs:dev Feb 7, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants