This repository has been archived by the owner on Jan 30, 2024. It is now read-only.
Make SecurityQuestion ActiveRecord class optional #131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The SecurityQuestion class is empty, and it's only needed if the `:security_questionable` option is turned on. Therefore, I think it should be up to the user to create the model if they need it. The problem with automatically creating and requiring the model is that it will override a class by the same name. I have my own implementation of security questions in my app, and was going crazy trying to figure out why the code I put in my `SecurityQuestion` class wasn't being recognized.
|
👍 just ran into this exact issue with one of our apps. |
|
Hello, and Happy New Year! Any thoughts on this PR? Is this project still being maintained? Thanks! |
|
Hello. Thoughts on this PR? |
|
I would love to see this merged as well. We've forked your branch and have been using it for this change since May of last year, thanks @monfresh. |
|
It looks like this was actually fixed at some point. The model was renamed to SecurityQuestionable. The git history seems to be messed up so I can't tell exactly what commit changed this. |
|
I was wrong. I was looking at the wrong thing. This issue still needs to be fixed. Re-opening my PR. @traxanos please consider merging this. Thanks! |
manno
pushed a commit
that referenced
this pull request
Mar 10, 2016
Make SecurityQuestion ActiveRecord class optional
|
Yay! Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The SecurityQuestion class is empty, and it's only needed if the
:security_questionableoption is turned on. Therefore, I think it should be up to the user to create the model if they need it.The problem with automatically creating and requiring the model is that it will override a class by the same name. I have my own implementation of security questions in my app, and was going crazy trying to figure out why the code I put in my
SecurityQuestionclass wasn't being recognized.