Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correctly expand CSS border-width property #68

Merged
merged 1 commit into from
Jun 9, 2021
Merged

Correctly expand CSS border-width property #68

merged 1 commit into from
Jun 9, 2021

Conversation

rockwotj
Copy link
Contributor

@rockwotj rockwotj commented Jun 9, 2021

According to https://developer.mozilla.org/en-US/docs/Web/CSS/border-width should support 2 value and 3 value variants and right now it doesn't.

According to https://developer.mozilla.org/en-US/docs/Web/CSS/border-width should support 2 value and 3 value variants and right now it doesn't.
@phax
Copy link
Owner

phax commented Jun 9, 2021

That's a tricky one, because it would also expand border-width: thick; to border-width: thick thick thick thick;

@rockwotj
Copy link
Contributor Author

rockwotj commented Jun 9, 2021

Isn't that the correct behavior? Chrome seems to tell me it is:

image

image

@rockwotj
Copy link
Contributor Author

rockwotj commented Jun 9, 2021

Today if I do: border-width: thick it gets expanded to border-width: thick 3px 3px 3px which seems wrong...

@phax
Copy link
Owner

phax commented Jun 9, 2021

Point taken 🤣

@phax phax merged commit fe77328 into phax:master Jun 9, 2021
@rockwotj rockwotj deleted the patch-1 branch June 9, 2021 15:00
@phax
Copy link
Owner

phax commented Jun 9, 2021

Are you having any more errors in the pipeline or can I build a 6.3.4 release? @rockwotj

@rockwotj
Copy link
Contributor Author

rockwotj commented Jun 9, 2021

No other errors at the moment, thanks!

phax added a commit that referenced this pull request Jun 9, 2021
@phax
Copy link
Owner

phax commented Jun 9, 2021

Great. Release 6.3.4 is on its way to Maven Central

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants