resolve zero port on all interfaces, not just localhost; GetPort rena… #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sangaman
suggested changes
Sep 17, 2019
…med to MustGetFreePort (according to go naming convention)
|
I have made a hard fork of this project here with this PR included: https://github.com/slimsag/freeport |
alessio
pushed a commit
to cosmos/cosmos-sdk
that referenced
this pull request
Mar 10, 2021
Replace defer l.Close() with l.Close() to shutdown the listener as fast as possible to avoid the "bind: address already in use" error that so often occurs in CI build. From: phayes/freeport#8 Reference: #6671
9 tasks
mergify bot
pushed a commit
to cosmos/cosmos-sdk
that referenced
this pull request
Mar 15, 2021
Replace defer l.Close() with l.Close() to shutdown the listener as fast as possible to avoid the "bind: address already in use" error that so often occurs in CI build. From: phayes/freeport#8 Reference: #6671 Co-authored-by: Amaury <1293565+amaurym@users.noreply.github.com>
daeMOn63
pushed a commit
to fetchai/cosmos-sdk
that referenced
this pull request
Aug 19, 2021
Replace defer l.Close() with l.Close() to shutdown the listener as fast as possible to avoid the "bind: address already in use" error that so often occurs in CI build. From: phayes/freeport#8 Reference: #6671 Co-authored-by: Amaury <1293565+amaurym@users.noreply.github.com>
daeMOn63
pushed a commit
to fetchai/cosmos-sdk
that referenced
this pull request
Aug 20, 2021
Replace defer l.Close() with l.Close() to shutdown the listener as fast as possible to avoid the "bind: address already in use" error that so often occurs in CI build. From: phayes/freeport#8 Reference: #6671 Co-authored-by: Amaury <1293565+amaurym@users.noreply.github.com>
daeMOn63
pushed a commit
to fetchai/cosmos-sdk
that referenced
this pull request
Mar 1, 2022
Replace defer l.Close() with l.Close() to shutdown the listener as fast as possible to avoid the "bind: address already in use" error that so often occurs in CI build. From: phayes/freeport#8 Reference: #6671 Co-authored-by: Amaury <1293565+amaurym@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi.
Thanks for the useful library / tool.
The main reasons for this pull request are:
l.Close()withl.Close()- I want to shutdown the listener as fast as possible to avoid "bind: address already in use"GetPortwas market as deprecated for 1 year, so I thought it wouldn't be much harm to rename it intoMustGetFreePortaccording to the go naming convention. It's nice to have such function for usage in tests.