-
-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unnecessary dependencies #70
Comments
Still playing with bsp-layout. When doing
But this is with |
hello @olafdietsche 👋 it appears
i am able to reproduce this, without could you file another issue about this bug? 😌 |
According to bash - Shell Arithmetic and various online sources, bash doesn't handle floating point by itself. The other issue is at https://github.com/phenax/bsp-layout/blob/master/src/layouts/tall.sh#L53:
and occurs, because of |
It looks like commit feae088 introduced this. There is a change replacing |
So, finally this issue is invalid and is the result of the mentioned commit. |
if you still have an issue, even though it's not relevant in this very issue and comes from another commit, you could file a new issue 😋 |
What did you expect to happen?
There should be no dependency to
bc
, because it isn't used anywhere in the scripts.What actually happened?
https://github.com/phenax/bsp-layout/blob/master/src/utils/common.sh aborts, if
bc
isn't installed.Describe your attempts to resolve the issue
Nothing done so far.
Steps to reproduce
mv /usr/bin/bc /usr/bin/bc.off
bsp-layout
bsp-layout
aborts with "[Missing dependency] bsp-layout needs bc installed"mv /usr/bin/bc.off /usr/bin/bc
System Information
I installed the
bsp-layout
command withmake DESTDIR=/tmp/destdir install
.The text was updated successfully, but these errors were encountered: