Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introducing new command: bsp-layouts select #75

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

Nonetss
Copy link

@Nonetss Nonetss commented May 30, 2024

This pull request introduces a new command, bsp-layouts select, aimed at enhancing accessibility when switching between different layouts. Upon executing this command, a Rofi menu will appear containing all the available layout types. This approach simplifies the process of changing layouts, making it more intuitive and user-friendly.

Screenshot_20240530_192829

@amtoine
Copy link
Collaborator

amtoine commented Jun 1, 2024

i'm not sure i'll have time to review this anytime soon...

however, i'm pretty impressed by the look of this menu of yours, well done 👏 👏

@phenax
Copy link
Owner

phenax commented Jun 2, 2024

This looks incredible! Although I'm not sure if adding rofi as a dependency for users who don't use it is a good idea. I think this should be a separate tool.

This would also be a great candidate for an external module that integrates with bsp-layout. For example, this command can be a separate package called bsp-layout-select and in bsp-layout, we can translate any call to bsp-layout some-module to bsp-layout-some-module like git does.

This has the advantage of not forcing a dependency on users and instead letting users opt-in to an external module by installing that package. @amtoine, what do you think?

@Nonetss
Copy link
Author

Nonetss commented Jun 2, 2024

Yes, I thought the same thing. In fact, on my computer, I have it implemented through an external script that I access from sxhdk to modify the layout. But since it seemed like a useful tool that people might find interesting, I decided to try incorporating it into the original project. The script is essentially what I have added to your repository. But if you want to take a look, I have it uploaded to this repo: https://github.com/Nonetss/sxhd-config in the scripts folder.

@amtoine
Copy link
Collaborator

amtoine commented Jun 2, 2024

@phenax, that sounds perfect to me 👌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants