Silhouette kmean #39
Silhouette kmean #39
Conversation
There was a problem hiding this comment.
Thanks so much @rogerkuou, looks great! Very nice idea to add the former k-means algorithm to the legacy folder. I think we should leave the set up as the results object as it was earlier, but for the rest all looks good!
tests/test_kmeans.py
Outdated
| [1, 1, 0] | ||
| [0, 0, 0, 1, 1], | ||
| [0, 0, 0, 1, 1], | ||
| [1, 1, 0, 0, 0], |
There was a problem hiding this comment.
To make it more self evident, wouldn't it be better to have Z[2,2] and Z[3,2] set to 1 as well?
There was a problem hiding this comment.
Thx Francesco! I changed this, and also found that equal numbers in a cluster may cause some statistics to be 0, which may lead to a 0 dividing issue. Therefore I also added a small perturbation to Z.
There was a problem hiding this comment.
Mmh, having maximum value equal to the minimum value in a co-cluster should currently raise a warning, but this is fine I think (the NaN values are then replaced with zeros afterwards).
|
Hi @fnattino, I updated the PR. Would you like to have a look? |
There was a problem hiding this comment.
Very nice work! I agree with @fnattino's comment but it looks like that has largely been addressed.
I have been wondering whether the ability to select or provide which statistical measures to use for the k-means might be desirable.
Fix statistic bug in legacy
Replace the elbow-curve method with the Silhouette analysis, to determine the number of k in K-Mean.