Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optionally include identifiers for taxa and characters (entities) in return value #2

Open
hlapp opened this issue Oct 15, 2015 · 4 comments
Labels
enhancement New feature or request

Comments

@hlapp
Copy link
Member

hlapp commented Oct 15, 2015

Taxon names can be ambiguous due to synonymies and homonymies. To facilitate integration of returned trait data matrices with other trait data, having also identifiers for taxa rather than just names can help greatly.

Some characters (entities) in a matrix may be known to be much more similar semantically (or conceptually) than others, but to assess this with metrics the entities need to be tied into an ontology. To enable this, the identifiers for characters (for pk_ontotrace, this would be the identifiers of their entities) are required.

The identifiers could all be queried for one-by-one from the Phenoscape API, but for larger matrices this may be time consuming, and because the identifiers are (or ought to be, see phenoscape/phenoscape-kb-services#20) already returned in NeXML from the Phenoscape API, having to query for them again seems unnecessary.

Initial plan for implementing this is to optionally return a list instead of a data.frame. The list would include the matrix, a table of taxon identifiers, and a table of entity identifiers. @sckott and @cboettig - are there better ways of doing this?

Implementing this depends on the metadata extraction in RNeXML getting fixed (see ropensci/RNeXML#129), and on character identifier annotations being added to the output NeXML in OntoTrace (see phenoscape/phenoscape-kb-services#20).

@sckott
Copy link
Member

sckott commented Oct 15, 2015

That seems reasonable to me. To be clear what are these taxa identifiers? I assume they are IDs used internally within Phenoscape?

@hlapp
Copy link
Member Author

hlapp commented Oct 15, 2015

To be clear what are these taxa identifiers? I assume they are IDs used internally within Phenoscape?

As for what we get back in the NeXML, these are VTO identifiers. Ideally there'd also be NCBI identifiers, I suppose (though they are only available for a small subset of VTO).

@hlapp
Copy link
Member Author

hlapp commented Dec 29, 2015

I think this was addressed at least for taxa in fe7d29e.

@hlapp hlapp added the enhancement New feature or request label Jan 16, 2019
@hlapp hlapp added this to the pre-2023-TraitFest milestone Nov 4, 2022
@hlapp
Copy link
Member Author

hlapp commented Nov 4, 2022

Should at least evaluated for current status prior to the TraitFest event. Not clear how of this is still relevant.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants