Skip to content
This repository has been archived by the owner on Mar 12, 2020. It is now read-only.

Add custom fixer for discussed styling #37

Merged
merged 5 commits into from
Oct 1, 2015
Merged

Add custom fixer for discussed styling #37

merged 5 commits into from
Oct 1, 2015

Conversation

enebe-nb
Copy link
Contributor

This will correctly catch this 2 styles:

  • Array syntax is [] or [ 'key' => 'value' ] (spaces after opening bracket and before closing bracket)
  • Multi line operations: The operator should be prepended to the front of the next line.

To add a travis check on code styling a dev dependency must be added. Since php can't reference classes from a phar archive. If you like then i could add this, just tell me.

Also, i sent this merge to cs-fixer branch to prepare it to merge in master after all styling is discussed.

@enebe-nb
Copy link
Contributor Author

Sorry, before i downloaded an old cs-fixer version and got a few errors while using it directly.
Travis integration is now added and an extra dependency is not needed.

This code will fail on travis, since the code doesn't follow the styling yet, but this will allow to see the travis' feedback.

@svpernova09
Copy link
Member

This looks good from here. @rocketpastsix will you have a look and double check. Thanks!

@matthewtrask
Copy link
Contributor

Looks good to me. @svpernova09

svpernova09 added a commit that referenced this pull request Oct 1, 2015
Add custom fixer for discussed styling
@svpernova09 svpernova09 merged commit 9eb1117 into phergie:code-style/php-cs-fixer Oct 1, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants