Handle the case of epmty msgid

[loicfevrier]

When the msgid is multi-lines, I prefer not to have to do the implode in my code (no need to duplicate this line).
This commit allow a simple
setEntry(NULL, $entry)

and the msgid will be computed at the line 443 (new_msgid) which handle correctly the multi-line case.

[pherrymason]

Mmm I'm not very sure about making the first argument "optional".
Maybe the solution is to keep an internal custom identifier to reference each entry and then read everything from the $entry argument.

So when the entries are parsed, PoParsed adds a custom identifier to each entry, for example:

$entries = [
    ['__id' => 0,
     'msgid' => ['a msgid'],
     'msgstr' => ['translation']
    ],
    ['__id' => 1,
     'msgid' => ['another msgid', 'multilined']
     'msgstr' => ['translation', 'of a multiline string']
    ]
  ];

setEntry then will try to read this __id field to identify the entry being edited. If not found it means it is a new one.

Then developer user of the library doesn't have to handle with this details which I recognise it is not very confortable to work with.

[loicfevrier]

Indeed.
Would you like me to developp it in that spirit or do you prefer to to it yourself ?

setEntry would become

setEntry($entry)

which would break compatibility.

[pherrymason]

You're very welcome to implement it! However I would add a change like that
in the 5.0 branch which already has that api, it only needs the internal id
El 03/06/2015 20:09, "Loïc Février" notifications@github.com escribió:

Indeed.
Would you like me to developp it in that spirit or do you prefer to to it
yourself ?

setEntry would become

setEntry($entry)

which would break compatibility.

—
Reply to this email directly or view it on GitHub
#45 (comment)
.

[dereuromark]

Also

case (strpos($state, 'msgstr[') !== false):

needs to be a bit more defensive (in my case null for some reason):

case ($state && strpos($state, 'msgstr[') !== false):

Shouldnt throw warnings here:

Notice (8): Undefined index:  [ROOT/vendor/sepia/po-parser/src/Sepia/PoParser.php, line 307]

[pherrymason]

Feel free to create a PR for this modification

[pherrymason]

This is no longer needed since #68
Thanks anyway!

#68 fixes your issue @dereuromark