Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RC Test: Build A Molecule 1.0.0-rc.1 #509

Closed
1 task
Denz1994 opened this issue Jun 20, 2020 · 4 comments
Closed
1 task

RC Test: Build A Molecule 1.0.0-rc.1 #509

Denz1994 opened this issue Jun 20, 2020 · 4 comments

Comments

@Denz1994
Copy link
Contributor

Denz1994 commented Jun 20, 2020

@ariel-phet , @arouinfar , build-a-molecule/1.0.0-rc.1 is ready for RC testing. Document issues in https://github.com/phetsims/build-a-molecule/issues and link to this issue.

Assigning to @ariel-phet for prioritization.

General RC Test

What to Test

  • Click every single button.
  • Test all possible forms of input.
    • Test all mouse/trackpad inputs.
    • Test all touchscreen inputs.
  • If there is sound, make sure it works.
  • Make sure you can't lose anything.
  • Play with the sim normally.
  • Try to break the sim.
  • Test all query parameters on all platforms. (See QA Book for a list of query parameters.)
  • Download HTML on Chrome and iOS.
  • Make sure the iFrame version of the simulation is working as intended on all platforms.
  • Make sure the XHTML version of the simulation is working as intended on all platforms.
  • Complete the test matrix.
  • Don't forget to make sure the sim works with Legends of Learning.
  • Check this LoL spreadsheet and notify AR or AM if it not there.
  • If this is rc.1 please do a memory test.
  • When making an issue, check to see if it was in a previously published version
  • Try to include version numbers for browsers
  • If there is a console available, check for errors and include them in the Problem Description.
  • As an RC begins and ends, check the sim repo. If there is a maintenance issue, check it and notify developers if there is a problem.

Focus and Special Instructions

This is the first RC, so there aren't many issues to verify and this sim has just completed a dev-test cycle. I would ask QA to pay close attention to the bonding behaviors of molecules, especially as mentioned in phetsims/build-a-molecule#197 (comment) and phetsims/build-a-molecule#148 (comment).

Issues to Verify

These issues should have the "status:ready-for-qa" label. Check these issues off and close them if they are fixed. Otherwise, post a comment in the issue saying that it wasn't fixed and link back to this issue. If the label is "status:ready-for-review" or "status:fixed-pending-deploy" then assign back to the developer when done, even if fixed.

Link(s)


FAQs for QA Members
There are multiple tests in this issue... Which test should I do first?

Test in order! Test the first thing first, the second thing second, and so on.


How should I format my issue?

Here's a template for making issues:

  <b>Test Device</b>

  blah

  <b>Operating System</b>

  blah

  <b>Browser</b>

  blah

  <b>Problem Description</b>

  blah

  <b>Steps to Reproduce</b>

  blah

  <b>Visuals</b>

  blah

  <details>
  <summary><b>Troubleshooting Information</b></summary>

  blah

  </details>

Who should I assign?

We typically assign the developer who opened the issue in the QA repository.


My question isn't in here... What should I do?

You should:

  1. Consult the QA Book.
  2. Google it.
  3. Ask Katie.
  4. Ask a developer.
  5. Google it again.
  6. Cry.


@ariel-phet
Copy link
Contributor

@KatieWoe could be done a a concurrent priority to #507

@KatieWoe
Copy link
Contributor

Memory Test:
Start: 308 MB
1 min: 324
2 min: 329
3 min: 331
4 min: 332
5 min: console crashed

It looks like a fairly big memory footprint, but without an obvious leaks. Leaving it up to @Denz1994 on if it needs to be addressed.

@Denz1994
Copy link
Contributor Author

It looks like a fairly big memory footprint, but without an obvious leaks. Leaving it up to @Denz1994 on if it needs to be addressed.

The memory footprint should be fairly large compared to other sims due to the size of the Pubchem data set. We've taken steps to optimize this in #phetsims/build-a-molecule#115 and #phetsims/build-a-molecule#173.

@Denz1994
Copy link
Contributor Author

Denz1994 commented Aug 19, 2020

As per a discussion on Slack with @ariel-phet, this issue will be closed and BAM should move to the next RC testing for spot-checking. Though the entire test matrix was not completed in this test we are confident enough to move forward to the next test cycle.

The remaining open issues will be assigned for spot-checking in the next QA cycle. Closing this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants