Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Proper Credits #168

Closed
Denz1994 opened this issue Mar 25, 2020 · 9 comments
Closed

Add Proper Credits #168

Denz1994 opened this issue Mar 25, 2020 · 9 comments
Assignees

Comments

@Denz1994
Copy link
Contributor

This issue is being opened to track changes to credits for 1.0.0 publication.

Currently, the credits are as follows:

  credits: {
    leadDesign: 'Amy Rouinfar',
    softwareDevelopment: 'Denzell Barnett, Johnathan Olson',
    team: 'Ariel Paul, Kathy Perkins',
    qualityAssurance: 'Ethan Johnson, Liam Mulhall, Benjamin Roberts, Jacob Romero,Kathryn Woessner'
  }

@arouinfar and @KatieWoe are there any others that should be added?

@KatieWoe
Copy link
Contributor

Logan Bray has done a fairly large amount on it. There also isn't a space between Jacob's name and mine

@arouinfar
Copy link
Contributor

@Denz1994 I added the legacy design team to the credits and addressed #168 (comment) in the above commit.

Back to @Denz1994 to decide whether or not to keep this issue open for finalizing QA credits once we're in rc or open a new issue when the time comes.

@Denz1994
Copy link
Contributor Author

Denz1994 commented Apr 8, 2020

I'll keep this issue open to finalize during RC.

@Denz1994
Copy link
Contributor Author

Denz1994 commented Aug 26, 2020

Should be verified once more in the latest RC.

@KatieWoe
Copy link
Contributor

Jaspe Arias and Steele Dalton should be added as well for rc.2

Denz1994 added a commit that referenced this issue Aug 28, 2020
@Denz1994
Copy link
Contributor Author

Credits have been updated.

@Denz1994
Copy link
Contributor Author

Denz1994 commented Sep 2, 2020

Closing this one.

@Denz1994 Denz1994 closed this as completed Sep 2, 2020
@KatieWoe
Copy link
Contributor

@arouinfar should you be added too?

@arouinfar
Copy link
Contributor

Thanks for checking @KatieWoe, but I'm already credited.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants