Skip to content

Commit

Permalink
Review comments, see: #268
Browse files Browse the repository at this point in the history
  • Loading branch information
marlitas committed Mar 14, 2023
1 parent 93425a3 commit f13b433
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 0 deletions.
1 change: 1 addition & 0 deletions js/common/view/CalculusGrapherControlPanel.ts
Original file line number Diff line number Diff line change
Expand Up @@ -73,6 +73,7 @@ export default class CalculusGrapherControlPanel extends Panel {
curveManipulationControls,
pushButtonGroup,

// REVIEW: I don't see any usage of appendContent in this repo. What is this safeguard for?
// Additional content added via appendContent will be below this separator.
// VBox will automatically hide the separator if there is nothing below it.
new HSeparator( { stroke: Color.grayColor( 200 ) } )
Expand Down
1 change: 1 addition & 0 deletions js/common/view/CalculusGrapherScreenIconFactory.ts
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,7 @@ function createOriginalShape(): Shape {

const shape = new Shape();
for ( let x = 0; x <= CURVE_WIDTH; x++ ) {

// sign is flipped for scenery view coordinate frame
const y = a * Math.exp( -Math.pow( x - b, 2 ) / ( 2 * c * c ) );
if ( x === 0 ) {
Expand Down

0 comments on commit f13b433

Please sign in to comment.