Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Making PredictionNode.visibleProperty 'true' doesn't check the corresponding checkbox #110

Closed
Nancy-Salpepi opened this issue Mar 24, 2022 · 3 comments

Comments

@Nancy-Salpepi
Copy link

Test device
MacBook Air (m1 chip)

Operating System
12.3

Browser
Chrome

Problem description
For phetsims/qa#789 and related to PhET-iO needs issue #105

When the medianPredictionNode.visibleProperty or meanPredictionNode.visibleProperty are set to true, the prediction arrow appears in the sim but the corresponding checkbox doesn't get checked.
This happens on both screens.

From CK on Slack:
Chris Klusendorf 5:43 PM
hey nice catch, you’re totally right. right now isShowingMeanPredictionProperty is linked up to control the visibility of that node, but it should be more direct, so that visibleProperty is the just same Property as the model Property. After trying it out, it should look like this in Studio.

Visuals

image

@samreid
Copy link
Member

samreid commented Mar 29, 2022

Thanks for reporting this issue. @chrisklus and I pushed a proposed fix that seems to be working in our tests. @Nancy-Salpepi can you please verify the behavior in phettest? Please mark ready for cherry picking if all is well.

@Nancy-Salpepi
Copy link
Author

Looks good in master.

@samreid
Copy link
Member

samreid commented Apr 6, 2022

@chrisklus and I confirmed this is fixed in in #122, closing.

@samreid samreid closed this as completed Apr 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants