Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Regression on Master regarding position of the equipotential tool. #146

Closed
veillette opened this issue Mar 14, 2018 · 3 comments
Closed

Regression on Master regarding position of the equipotential tool. #146

veillette opened this issue Mar 14, 2018 · 3 comments
Assignees
@veillette

Comments

@veillette
Copy link
Contributor

While working on #98, i noticed that the equipotential sensor tool moves to the upper left corner of the dev bounds when one attempts to grab it from the toolbox.
@phet-steele phet-steele mentioned this issue Mar 16, 2018
Closed
@jonathanolson jonathanolson self-assigned this Mar 16, 2018
@jonathanolson
Copy link
Contributor

Probably DragListener regression, I'll look into it.

jonathanolson added a commit that referenced this issue Mar 16, 2018
@jonathanolson
Pass the node through to the press, see #146
7030310
@jonathanolson
Copy link
Contributor

I believe I've fixed this with the above commit. @veillette can you verify?

@veillette
Copy link
Contributor Author

Thanks @jonathanolson , this does indeed fix it. Closing

@veillette veillette mentioned this issue Mar 20, 2018
Open
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@veillette veillette

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jonathanolson @veillette