-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update lint and related projects #1275
Comments
Completed and I notified the slack dev-public team. I feel like a spot-check review would be good, and let's wait to see how CT does with these changes. I'll randomly choose a reviewer: @chrisklus can you please take a look at your convenience? |
@jessegreenberg and I discovered that recent changes here likely disrupt eslint in Webstorm, at least on Windows. It shows the salmon dialog at the top and says it cannot find a plugin. We continue to investigate. |
According to https://eslint.org/docs/latest/user-guide/configuring/plugins
I believe this is a new change. But from change logs it looks like this change may have been introduced in 7.0 so I'm not sure why the error was picked up now. But as @jessegreenberg and I saw, installing |
@jessegreenberg discovered WebStorm 2021 does not handle the relative plugin directory properly, see https://youtrack.jetbrains.com/issue/WEB-54388/Extra-eslint-options-are-not-applied-when-using-Eslint-8. So devs will need to update to WebStorm 2022.1.1 or higher after pulling (and npm update) these chipper changes. |
I reviewed the update commit in comparison with the stack overflow thread and all is looking good to me. I believe these changes have been working well for everyone on the team after updating WebStorm. Back to @samreid to close if all set here. |
Thanks, closing. |
This week we plan to have a TypeScript sprint, which will use lint for checking some of the patterns. I thought this would be a good opportunity to update our lint dependencies in advance.
Some breaking changes were noted in the change logs, but I tested the main processes and tested breaking a few lint rules and confirmed things seem to be working. Also, somehow this caught several missing semicolons which had been bothering me.
https://github.com/eslint/eslint/releases?page=1
https://stackoverflow.com/questions/69554485/eslint-error-must-use-import-to-load-es-module describes how to update the parser accordingly.
The text was updated successfully, but these errors were encountered: