-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
List all provided TypeScript ESLint rules #1277
Comments
I added a rule that seemed to match with our conventions, |
…an-literal-compare, see phetsims/chipper#1277
…an-literal-compare, see phetsims/chipper#1277
…an-literal-compare, see phetsims/chipper#1277
…an-literal-compare, see phetsims/chipper#1277
…an-literal-compare, see phetsims/chipper#1277
…an-literal-compare, see phetsims/chipper#1277
…an-literal-compare, see phetsims/chipper#1277
There are about 30 remaining rules that are marked as |
While working on #1368 I noticed that explicit-module-boundary-types was enabled for this issue. It has a lot of overlap with our custom explicit-method-return-types, I am wondering if we can delete explicit-method-return-types now. |
This issue has no assignments and @jessegreenberg's question seems worthy to bring return to |
Regarding #1277 (comment), explicit-module-boundary-types does not require return types for private functions. So I prefer our custom explicit-method-return-types and think we should keep it. Our rule also has an auto fix which is nice to keep around. Ill remove from agenda since that is why it was added. |
After #1276, we should follow that same convention for listing all of the existing TypeScript ESLint rules. We can add comments about why our team has enabled or disabled a rule.
I have converted to this form on my working copy but have more adjustments before I'll be ready to commit. Probably some time Monday.
Heads up to @jessegreenberg who did the initial work on setting up TypeScript ESLint rules.
The text was updated successfully, but these errors were encountered: