Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Naming of Curve properties #54

Closed
jonathanolson opened this issue Aug 13, 2015 · 2 comments
Closed

Naming of Curve properties #54

jonathanolson opened this issue Aug 13, 2015 · 2 comments
Assignees
@jonathanolson
Labels
dev:code-review

Comments

@jonathanolson
Copy link
Contributor

_orderOfFit and _fitType are both properties, so it seems clearer if they had the 'Property' suffix (as is very typical for properties).

Review: #31
andrey-zelenkov added a commit that referenced this issue Aug 27, 2015
@andrey-zelenkov
#54 added Property suffix to _orderOfFit and _fitType variables
67f8c33
@andrey-zelenkov
Copy link
Contributor

Added Property suffix to _orderOfFit and _fitType variables. Reassign to @jonathanolson for verification.

@jonathanolson
Copy link
Contributor Author

Looks good, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jonathanolson jonathanolson

Labels
dev:code-review
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jonathanolson @andrey-zelenkov