-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
phetioFeatured overrides #309
Comments
Overrides have been committed. Leaving self-assigned to review in master. |
@chrisklus in reviewing the featured elements in studio, I noticed that the things we'd featured in the overrides for beakerGroup.archetype and blockGroup.archetype aren't showing up. Can you investigate? Edit: beakerProxyNodeGroup.archetype.pickableProperty and blockNodeGroup.archetype.pickableProperty were also featured in the overrides, but do not appear featured in studio. |
Remaining issues:
|
@arouinfar the archetypes themselves were not featured in the overrides files, so I featured them for I also featured the specified tandems from your list above that were added in #307 (comment). |
That's really strange. Here's the text file with the overrides I committed. There are 9 instances of When I opened master in Chrome, I still wasn't seeing the archetypes featured. Hard refreshing and |
@chrisklus thanks for featuring the |
Related to #216
@kathy-phet and I have gone through studio and have decided which things should be featured. I will commit the changes to energy-forms-and-changes-phet-io-elements-overrides.js
and reference this issue.
The text was updated successfully, but these errors were encountered: