Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

phetioFeatured overrides #309

Closed
arouinfar opened this issue Feb 6, 2020 · 6 comments
Closed

phetioFeatured overrides #309

arouinfar opened this issue Feb 6, 2020 · 6 comments

Comments

@arouinfar
Copy link
Contributor

Related to #216

@kathy-phet and I have gone through studio and have decided which things should be featured. I will commit the changes to energy-forms-and-changes-phet-io-elements-overrides.js
and reference this issue.

@arouinfar arouinfar self-assigned this Feb 6, 2020
arouinfar added a commit that referenced this issue Feb 6, 2020
@arouinfar
Copy link
Contributor Author

Overrides have been committed. Leaving self-assigned to review in master.

@arouinfar
Copy link
Contributor Author

arouinfar commented Feb 7, 2020

@chrisklus in reviewing the featured elements in studio, I noticed that the things we'd featured in the overrides for beakerGroup.archetype and blockGroup.archetype aren't showing up. Can you investigate?

Edit: beakerProxyNodeGroup.archetype.pickableProperty and blockNodeGroup.archetype.pickableProperty were also featured in the overrides, but do not appear featured in studio.

@arouinfar
Copy link
Contributor Author

arouinfar commented Feb 7, 2020

Remaining issues:

  • Archetypes which are featured in energy-forms-and-changes-phet-io-elements-overrides.js do not appear featured in studio.
  • The panel around the biker's slider isn't instrumented yet. When it is, we'll need to feature the panel's visibleProperty.
  • sunProportionProperty (1 - cloudinessProportionProperty) will also need to be featured once it is added.
  • TimeControlNode's top-level enabledProperty and visibleProperty should be featured, but that may happen in common code not overrides, see TimeControlNode phetioFeatured defaults scenery-phet#577
  • We did not use overrides to feature anything in general or homeScreen. That will be handled in common code, but that work is still ongoing.

@arouinfar arouinfar removed their assignment Feb 7, 2020
chrisklus added a commit that referenced this issue Feb 13, 2020
@chrisklus
Copy link
Contributor

@arouinfar the archetypes themselves were not featured in the overrides files, so I featured them for beakerGroup and blockGroup. I see them showing up in Studio under featured as well as their Properties that you featured. Let me know if this was the right direction or if I'm misunderstanding.

I also featured the specified tandems from your list above that were added in #307 (comment).

@arouinfar
Copy link
Contributor Author

@arouinfar the archetypes themselves were not featured in the overrides files, so I featured them for beakerGroup and blockGroup. I see them showing up in Studio under featured as well as their Properties that you featured. Let me know if this was the right direction or if I'm misunderstanding.

That's really strange. Here's the text file with the overrides I committed. There are 9 instances of archetype in the file.
EFAC-overrides.txt

When I opened master in Chrome, I still wasn't seeing the archetypes featured. Hard refreshing and cacheBust didn't work, but loading studio in a incognito window did the trick. Pesky cache...

@arouinfar
Copy link
Contributor Author

@chrisklus thanks for featuring the sunProprotionProperty and the cloudsPanel.visibleProperty. I don't believe there's anything else left do for this issue, so I'll go ahead and close.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants