non-standard energy colors

[pixelzoom]

From phetsims/scenery-phet#455 (comment):

PhetColorScheme:

var RED_COLORBLIND = new Color( 255, 85, 0 );
var TAN_ORANGE = new Color( 236, 153, 55 );

HEAT_THERMAL_ENERGY: RED_COLORBLIND,
...
KINETIC_ENERGY: Color.GREEN,  // 0,255,0
...
POTENTIAL_ENERGY: Color.BLUE, // 0,0,255
...
TOTAL_ENERGY: TAN_ORANGE,

EnergySkateParkColorScheme:

    kineticEnergy: new Color( '#00cc1a' ),
    potentialEnergy: new Color( '#3282D7' ),
    thermalEnergy: new Color( '#FF5500' ), // red colorblind
    totalEnergy: new Color( '#B4B400' ), // dirty yellow

@arouinfar is there any reason why EnergySkateParkColorScheme should not be using PhetColorScheme?

[arouinfar]

Thanks @pixelzoom. All PhET sims should use the same colors for the various energies, but PhetColorScheme is a bit antiquated. Changes to PhetColorScheme will be discussed in phetsims/scenery-phet#456, so marking this as status:on-hold until that issue is resolved.

[arouinfar]

@jessegreenberg, in phetsims/scenery-phet#456 the colors used for energy were updated in PhetColorScheme.js. ESP should be using PhetColorScheme for the energy colors in EnergySkateParkColorScheme. I'd imagine that ESPB uses the same color scheme, but to be clear, the change should apply to both sims.

[jessegreenberg]

Alright, this sim (and therefore basics version) is using PhetColorScheme for the energies. Colors before (published version):

Colors after (master):

Closing.