Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CT: Cannot read properties of undefined (reading 'play') #243

Closed
pixelzoom opened this issue Jan 4, 2024 · 2 comments
Closed

CT: Cannot read properties of undefined (reading 'play') #243

pixelzoom opened this issue Jan 4, 2024 · 2 comments
Assignees
@pixelzoom
Labels
type:automated-testing type:duplicate This issue or pull request already exists

Comments

@pixelzoom
Copy link
Contributor

pixelzoom commented Jan 4, 2024 •
edited
Loading

Occurring occassionally:

fourier-making-waves : fuzz : built
http://128.138.93.172/continuous-testing/ct-snapshots/1704382578286/fourier-making-waves/build/phet/fourier-making-waves_en_phet.html?continuousTest=%7B%22test%22%3A%5B%22fourier-making-waves%22%2C%22fuzz%22%2C%22built%22%5D%2C%22snapshotName%22%3A%22snapshot-1704382578286%22%2C%22timestamp%22%3A1704384323631%7D&fuzz
Query: fuzz
Uncaught TypeError: Cannot read properties of undefined (reading 'play')
TypeError: Cannot read properties of undefined (reading 'play')
at <unknown> (http://128.138.93.172/continuous-testing/ct-snapshots/1704382578286/fourier-making-waves/build/phet/fourier-making-waves_en_phet.html?continuousTest=%7B%22test%22%3A%5B%22fourier-making-waves%22%2C%22fuzz%22%2C%22built%22%5D%2C%22snapshotName%22%3A%22snapshot-1704382578286%22%2C%22timestamp%22%3A1704384323631%7D&fuzz:1012:1483806)
at In.emit (http://128.138.93.172/continuous-testing/ct-snapshots/1704382578286/fourier-making-waves/build/phet/fourier-making-waves_en_phet.html?continuousTest=%7B%22test%22%3A%5B%22fourier-making-waves%22%2C%22fuzz%22%2C%22built%22%5D%2C%22snapshotName%22%3A%22snapshot-1704382578286%22%2C%22timestamp%22%3A1704384323631%7D&fuzz:1012:24838)
at In.notifyListeners (http://128.138.93.172/continuous-testing/ct-snapshots/1704382578286/fourier-making-waves/build/phet/fourier-making-waves_en_phet.html?continuousTest=%7B%22test%22%3A%5B%22fourier-making-waves%22%2C%22fuzz%22%2C%22built%22%5D%2C%22snapshotName%22%3A%22snapshot-1704382578286%22%2C%22timestamp%22%3A1704384323631%7D&fuzz:1012:26261)
at In.set (http://128.138.93.172/continuous-testing/ct-snapshots/1704382578286/fourier-making-waves/build/phet/fourier-making-waves_en_phet.html?continuousTest=%7B%22test%22%3A%5B%22fourier-making-waves%22%2C%22fuzz%22%2C%22built%22%5D%2C%22snapshotName%22%3A%22snapshot-1704382578286%22%2C%22timestamp%22%3A1704384323631%7D&fuzz:1012:25996)
at In.set (http://128.138.93.172/continuous-testing/ct-snapshots/1704382578286/fourier-making-waves/build/phet/fourier-making-waves_en_phet.html?continuousTest=%7B%22test%22%3A%5B%22fourier-making-waves%22%2C%22fuzz%22%2C%22built%22%5D%2C%22snapshotName%22%3A%22snapshot-1704382578286%22%2C%22timestamp%22%3A1704384323631%7D&fuzz:1012:472955)
at set value [as value] (http://128.138.93.172/continuous-testing/ct-snapshots/1704382578286/fourier-making-waves/build/phet/fourier-making-waves_en_phet.html?continuousTest=%7B%22test%22%3A%5B%22fourier-making-waves%22%2C%22fuzz%22%2C%22built%22%5D%2C%22snapshotName%22%3A%22snapshot-1704382578286%22%2C%22timestamp%22%3A1704384323631%7D&fuzz:1012:25907)
at Tf.hideListBox (http://128.138.93.172/continuous-testing/ct-snapshots/1704382578286/fourier-making-waves/build/phet/fourier-making-waves_en_phet.html?continuousTest=%7B%22test%22%3A%5B%22fourier-making-waves%22%2C%22fuzz%22%2C%22built%22%5D%2C%22snapshotName%22%3A%22snapshot-1704382578286%22%2C%22timestamp%22%3A1704384323631%7D&fuzz:1012:1490171)
at dismissWithFocusListener (http://128.138.93.172/continuous-testing/ct-snapshots/1704382578286/fourier-making-waves/build/phet/fourier-making-waves_en_phet.html?continuousTest=%7B%22test%22%3A%5B%22fourier-making-waves%22%2C%22fuzz%22%2C%22built%22%5D%2C%22snapshotName%22%3A%22snapshot-1704382578286%22%2C%22timestamp%22%3A1704384323631%7D&fuzz:1012:1488840)
at r.emit (http://128.138.93.172/continuous-testing/ct-snapshots/1704382578286/fourier-making-waves/build/phet/fourier-making-waves_en_phet.html?continuousTest=%7B%22test%22%3A%5B%22fourier-making-waves%22%2C%22fuzz%22%2C%22built%22%5D%2C%22snapshotName%22%3A%22snapshot-1704382578286%22%2C%22timestamp%22%3A1704384323631%7D&fuzz:1012:24838)
at r._notifyListeners (http://128.138.93.172/continuous-testing/ct-snapshots/1704382578286/fourier-making-waves/build/phet/fourier-making-waves_en_phet.html?continuousTest=%7B%22test%22%3A%5B%22fourier-making-waves%22%2C%22fuzz%22%2C%22built%22%5D%2C%22snapshotName%22%3A%22snapshot-1704382578286%22%2C%22timestamp%22%3A1704384323631%7D&fuzz:1012:18687)
[URL] http://128.138.93.172/continuous-testing/aqua/html/sim-test.html?url=..%2F..%2Fct-snapshots%2F1704382578286%2Ffourier-making-waves%2Fbuild%2Fphet%2Ffourier-making-waves_en_phet.html&simQueryParameters=fuzz&duration=80000&testInfo=%7B%22test%22%3A%5B%22fourier-making-waves%22%2C%22fuzz%22%2C%22built%22%5D%2C%22snapshotName%22%3A%22snapshot-1704382578286%22%2C%22timestamp%22%3A1704384323631%7D
[NAVIGATED] http://128.138.93.172/continuous-testing/aqua/html/sim-test.html?url=..%2F..%2Fct-snapshots%2F1704382578286%2Ffourier-making-waves%2Fbuild%2Fphet%2Ffourier-making-waves_en_phet.html&simQueryParameters=fuzz&duration=80000&testInfo=%7B%22test%22%3A%5B%22fourier-making-waves%22%2C%22fuzz%22%2C%22built%22%5D%2C%22snapshotName%22%3A%22snapshot-1704382578286%22%2C%22timestamp%22%3A1704384323631%7D
[NAVIGATED] about:blank
[NAVIGATED] http://128.138.93.172/continuous-testing/ct-snapshots/1704382578286/fourier-making-waves/build/phet/fourier-making-waves_en_phet.html?continuousTest=%7B%22test%22%3A%5B%22fourier-making-waves%22%2C%22fuzz%22%2C%22built%22%5D%2C%22snapshotName%22%3A%22snapshot-1704382578286%22%2C%22timestamp%22%3A1704384323631%7D&fuzz
[CONSOLE] continuous-test-load
[PAGE ERROR] Error: TypeError: Cannot read properties of undefined (reading 'play')
at http://128.138.93.172/continuous-testing/ct-snapshots/1704382578286/fourier-making-waves/build/phet/fourier-making-waves_en_phet.html?continuousTest=%7B%22test%22%3A%5B%22fourier-making-waves%22%2C%22fuzz%22%2C%22built%22%5D%2C%22snapshotName%22%3A%22snapshot-1704382578286%22%2C%22timestamp%22%3A1704384323631%7D&fuzz:1012:1483806
at In.emit (http://128.138.93.172/continuous-testing/ct-snapshots/1704382578286/fourier-making-waves/build/phet/fourier-making-waves_en_phet.html?continuousTest=%7B%22test%22%3A%5B%22fourier-making-waves%22%2C%22fuzz%22%2C%22built%22%5D%2C%22snapshotName%22%3A%22snapshot-1704382578286%22%2C%22timestamp%22%3A1704384323631%7D&fuzz:1012:24838)
at In.notifyListeners (http://128.138.93.172/continuous-testing/ct-snapshots/1704382578286/fourier-making-waves/build/phet/fourier-making-waves_en_phet.html?continuousTest=%7B%22test%22%3A%5B%22fourier-making-waves%22%2C%22fuzz%22%2C%22built%22%5D%2C%22snapshotName%22%3A%22snapshot-1704382578286%22%2C%22timestamp%22%3A1704384323631%7D&fuzz:1012:26261)
at In.set (http://128.138.93.172/continuous-testing/ct-snapshots/1704382578286/fourier-making-waves/build/phet/fourier-making-waves_en_phet.html?continuousTest=%7B%22test%22%3A%5B%22fourier-making-waves%22%2C%22fuzz%22%2C%22built%22%5D%2C%22snapshotName%22%3A%22snapshot-1704382578286%22%2C%22timestamp%22%3A1704384323631%7D&fuzz:1012:25996)
at In.set (http://128.138.93.172/continuous-testing/ct-snapshots/1704382578286/fourier-making-waves/build/phet/fourier-making-waves_en_phet.html?continuousTest=%7B%22test%22%3A%5B%22fourier-making-waves%22%2C%22fuzz%22%2C%22built%22%5D%2C%22snapshotName%22%3A%22snapshot-1704382578286%22%2C%22timestamp%22%3A1704384323631%7D&fuzz:1012:472955)
at set value [as value] (http://128.138.93.172/continuous-testing/ct-snapshots/1704382578286/fourier-making-waves/build/phet/fourier-making-waves_en_phet.html?continuousTest=%7B%22test%22%3A%5B%22fourier-making-waves%22%2C%22fuzz%22%2C%22built%22%5D%2C%22snapshotName%22%3A%22snapshot-1704382578286%22%2C%22timestamp%22%3A1704384323631%7D&fuzz:1012:25907)
at Tf.hideListBox (http://128.138.93.172/continuous-testing/ct-snapshots/1704382578286/fourier-making-waves/build/phet/fourier-making-waves_en_phet.html?continuousTest=%7B%22test%22%3A%5B%22fourier-making-waves%22%2C%22fuzz%22%2C%22built%22%5D%2C%22snapshotName%22%3A%22snapshot-1704382578286%22%2C%22timestamp%22%3A1704384323631%7D&fuzz:1012:1490171)
at dismissWithFocusListener (http://128.138.93.172/continuous-testing/ct-snapshots/1704382578286/fourier-making-waves/build/phet/fourier-making-waves_en_phet.html?continuousTest=%7B%22test%22%3A%5B%22fourier-making-waves%22%2C%22fuzz%22%2C%22built%22%5D%2C%22snapshotName%22%3A%22snapshot-1704382578286%22%2C%22timestamp%22%3A1704384323631%7D&fuzz:1012:1488840)
at r.emit (http://128.138.93.172/continuous-testing/ct-snapshots/1704382578286/fourier-making-waves/build/phet/fourier-making-waves_en_phet.html?continuousTest=%7B%22test%22%3A%5B%22fourier-making-waves%22%2C%22fuzz%22%2C%22built%22%5D%2C%22snapshotName%22%3A%22snapshot-1704382578286%22%2C%22timestamp%22%3A1704384323631%7D&fuzz:1012:24838)
at r._notifyListeners (http://128.138.93.172/continuous-testing/ct-snapshots/1704382578286/fourier-making-waves/build/phet/fourier-making-waves_en_phet.html?continuousTest=%7B%22test%22%3A%5B%22fourier-making-waves%22%2C%22fuzz%22%2C%22built%22%5D%2C%22snapshotName%22%3A%22snapshot-1704382578286%22%2C%22timestamp%22%3A1704384323631%7D&fuzz:1012:18687)
[CONSOLE] continuous-test-error

id: "Sparky Node Puppeteer"
Snapshot from 1/4/2024, 8:36:18 AM
@pixelzoom pixelzoom self-assigned this Jan 4, 2024
@pixelzoom
Copy link
Contributor Author

pixelzoom commented Jan 4, 2024 •
edited
Loading

Running locally, I hit this assertion in ComboBoxListBox:

const selectionIndex = this.getVisibleListItemNodes().indexOf( this.selectionOnFireAction );
assert && assert( selectionIndex !== -1, 'sound generation does not support adding new items' );

This is something that @jbphet and I added recently, while working on phetsims/sun#861. I'm not sure how new items are possibly being added, will need to investigate. Perhaps there's a bug in ComboBoxListBox that assumes that all items are initially visible.

I'm also not sure whether this is the cause of the failure being reported by CT.

@pixelzoom pixelzoom mentioned this issue Jan 8, 2024
Closed
@pixelzoom
Copy link
Contributor Author

This is a duplicate of #244. Here's the relevant code in ComboBoxListBox. #244 is failing the assertion. This issue is failing the next line because the test is "fuzz : built", and assertions are stripped out of built versions.

           // The selected item didn't provide a sound player, so use a default based on its position within the list
           // of visible selections.
           const selectionIndex = this.getVisibleListItemNodes().indexOf( this.selectionOnFireAction );
           assert && assert( selectionIndex !== -1, 'sound generation does not support adding new items' );
           defaultItemSelectedSoundPlayers[ selectionIndex ].play();

@pixelzoom pixelzoom added the type:duplicate This issue or pull request already exists label Jan 8, 2024
pixelzoom added a commit to phetsims/sun that referenced this issue Jan 8, 2024
@pixelzoom
play sound for selected item only if it's still visible, phetsims/fou…
ab87ee8 
…rier-making-waves#244, phetsims/fourier-making-waves#243
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pixelzoom pixelzoom

Labels
type:automated-testing type:duplicate This issue or pull request already exists
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@pixelzoom