Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(Description) Check screen reader behaviour #243

Closed
3 of 4 tasks
terracoda opened this issue Sep 24, 2021 · 14 comments
Closed
3 of 4 tasks

(Description) Check screen reader behaviour #243

terracoda opened this issue Sep 24, 2021 · 14 comments

Comments

@terracoda
Copy link
Contributor

terracoda commented Sep 24, 2021

Before RC we need to do sanity checks on screen reader experience for any major issues.

  • VoiceOver
  • iOS VoiceOver (iOS 14.7.1 and 14.6)
  • NVDA
  • JAWS

Note that in BASE issue https://github.com/phetsims/balloons-and-static-electricity/issues/508 we deferred some work in common code that would fix the mobile drag and grab interaction. Currently the visual keyboard grab hint shows up on touch devices.

We may need to continue to defer mobile accessibility for Friction as well if this common code issue cannot be addressed in a timely fashion.

UPDATE FROM MK: yes, mobile description a11y is deferred, see doc in #249

@terracoda
Copy link
Contributor Author

terracoda commented Sep 24, 2021

VoiceOver issues on MacOs 11.4

  1. The reset hint has been permanently appended to the settled state, "Atoms jiggle a tiny bit, temperature cool. Reset sim to make more observations."

    • the reset hint has to be conditionally appended. It can't be heard if atoms are available to be evaporated.
  2. There is a huge amount of pile-ups. Hopefully, we have modernized the management of responses and it will be straightforward to address the pileups.

@terracoda
Copy link
Contributor Author

terracoda commented Sep 24, 2021

VoiceOver issues on iOS 14.7.1 (iPhone 7)

  1. See visual keyboard hint on touch device (iphone) as noted in https://github.com/phetsims/balloons-and-static-electricity/issues/508
  • this needs to fixed in common code, or we leave iOS off for this release
  1. Hear ticking as sim loads (this must be built-in apple sonification)
  2. Screen reader behaviour is erratic. At first I could access state descriptions with swipes, now I can. At first, I was hearing pile-ups of responses and now I hear no responses. I only hear state descriptions.

@terracoda
Copy link
Contributor Author

terracoda commented Sep 24, 2021

VoiceOver issues on iOS 14.6 (iPhone 8)

  1. keyboard grab hint visible (same as above)
  2. no ticking noise heard on iPhone 8 when sim was loading
  3. significant response pile ups happen. Hints like move down to rub harder and rub fast or slow seemed to interrupt more important warming-cooling responses and break away responses. But like above on subsequent testing I no longer hear responses. I can still access state descriptions.

@terracoda terracoda removed their assignment Sep 24, 2021
@terracoda
Copy link
Contributor Author

@Matthew-Moore240 please do a quick test with NVDA to see if there are obvious issues with pileups on that platform as well.

@zepumph
Copy link
Member

zepumph commented Sep 30, 2021

From testing on NVDA:

@zepumph
Copy link
Member

zepumph commented Oct 1, 2021

On hold until #253 can be fixed. That issue is too large to get good results from other testing.

@terracoda
Copy link
Contributor Author

Also noting this version of Friction will not be published with iOS Interactive Description, so we will not be addressing https://github.com/phetsims/balloons-and-static-electricity/issues/508

@zepumph
Copy link
Member

zepumph commented Oct 6, 2021

Agreed! See #249 for notes on the discussion we had.

@zepumph
Copy link
Member

zepumph commented Oct 8, 2021

Ok, #253 is done. Ready for a final review with PDOM again.

@zepumph
Copy link
Member

zepumph commented Oct 8, 2021

Review on hold until #258, I'll give a dev version when ready.

@zepumph
Copy link
Member

zepumph commented Oct 8, 2021

Alright, ready to review, please test with https://phet-dev.colorado.edu/html/friction/1.6.0-dev.18/phet/friction_all_phet.html

@terracoda
Copy link
Contributor Author

I checked VO on MacOS and VO on iOS. Both sound pretty good. VO on iOS will need a bit more work, but this version is being published with iOS A11y.

For iOS, just noting along with the visual keyboard hint, I had some pile ups of move down to rub harder.

@terracoda terracoda removed their assignment Oct 8, 2021
@Matthew-Moore240
Copy link

This all sounded really good to me. The only thing was that I had to do the long swipes across the book to get the now hotter and warming alerts but I had no pile-up or anything like that.

@Matthew-Moore240 Matthew-Moore240 removed their assignment Oct 8, 2021
@zepumph
Copy link
Member

zepumph commented Oct 8, 2021

Ready to close. Thanks!

@zepumph zepumph closed this as completed Oct 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants