-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(Description) Check screen reader behaviour #243
Comments
VoiceOver issues on MacOs 11.4
|
VoiceOver issues on iOS 14.7.1 (iPhone 7)
|
VoiceOver issues on iOS 14.6 (iPhone 8)
|
@Matthew-Moore240 please do a quick test with NVDA to see if there are obvious issues with pileups on that platform as well. |
From testing on NVDA:
|
On hold until #253 can be fixed. That issue is too large to get good results from other testing. |
Also noting this version of Friction will not be published with iOS Interactive Description, so we will not be addressing https://github.com/phetsims/balloons-and-static-electricity/issues/508 |
Agreed! See #249 for notes on the discussion we had. |
Ok, #253 is done. Ready for a final review with PDOM again. |
Review on hold until #258, I'll give a dev version when ready. |
Alright, ready to review, please test with https://phet-dev.colorado.edu/html/friction/1.6.0-dev.18/phet/friction_all_phet.html |
I checked VO on MacOS and VO on iOS. Both sound pretty good. VO on iOS will need a bit more work, but this version is being published with iOS A11y. For iOS, just noting along with the visual keyboard hint, I had some pile ups of move down to rub harder. |
This all sounded really good to me. The only thing was that I had to do the long swipes across the book to get the now hotter and warming alerts but I had no pile-up or anything like that. |
Ready to close. Thanks! |
Before RC we need to do sanity checks on screen reader experience for any major issues.
Note that in BASE issue https://github.com/phetsims/balloons-and-static-electricity/issues/508 we deferred some work in common code that would fix the mobile drag and grab interaction. Currently the visual keyboard grab hint shows up on touch devices.
We may need to continue to defer mobile accessibility for Friction as well if this common code issue cannot be addressed in a timely fashion.
UPDATE FROM MK: yes, mobile description a11y is deferred, see doc in #249
The text was updated successfully, but these errors were encountered: