Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address confusion related to Principal rays #140

Closed
sarchang opened this issue Jul 28, 2021 · 10 comments
Closed

Address confusion related to Principal rays #140

sarchang opened this issue Jul 28, 2021 · 10 comments

Comments

@sarchang
Copy link
Contributor

sarchang commented Jul 28, 2021

Some students were confused when comparing Many Rays to Principal Rays because in Many Rays, rays that don't pass through the optic are straight, but in Principal Rays, rays that don't pass through the optic are still reflected/refracted.
image
image

The top and bottom principal rays should be dashed lines to emphasize that they do not represent real light rays like the ones in Many Rays.

@veillette
Copy link
Contributor

veillette commented Jul 28, 2021

To clarify, only the portion of the ray that extends beyond vertical optic line (but without passing through the optic) should be dashed.

In the case of the mirror, the "reflected" ray should be dashed if the ray does not go hit the mirror.

@pixelzoom
Copy link
Contributor

pixelzoom commented Oct 21, 2021

Note that this will influence how #125 is addressed:

@pixelzoom
Copy link
Contributor

@arouinfar Does this need to be addressed, or should it be closed?

@pixelzoom
Copy link
Contributor

Discussed with @arouinfar on Zoom, yes we want to do this.

@pixelzoom pixelzoom assigned pixelzoom and unassigned arouinfar Oct 26, 2021
@pixelzoom pixelzoom removed the dev:enhancement New feature or request label Jan 5, 2022
@pixelzoom
Copy link
Contributor

pixelzoom commented Jan 5, 2022

I wasn't totally clear on what is desired here, so I discussed with @arouinfar on Zoom.

Several of the comments above referred to "dotted" lines. Dashed lines are desired, not dotted. I've edited the comments to prevent confusion.

The screenshots below show the scenarios that we need to handle. The red arrows point to the ray segments that should be dashed.


Convex Lens + Real Image

140-lens-real


Convex Lens + Virtual Image

140-lens-virtual


Concave Lens + Virtual Image

export


Concave Mirror + Real Image

140-mirror-real


Concave Mirror + Virtual Image

140-mirror-virtual


Convex Mirror + Virtual Image

140-mirror-virtual2

@pixelzoom
Copy link
Contributor

pixelzoom commented Jan 11, 2022

@arouinfar proposed that virtual rays would look nicer using dashed line style. I prototyped this, ran it past @arouinfar, and she liked it. So it's implemented in the above commit. The screenshot below shows an example.

This makes it problematic to use a dashed line style for some of the real ray segments. I have some other ideas for how to address that, which I'll work on next.

screenshot_1516

@pixelzoom
Copy link
Contributor

pixelzoom commented Jan 11, 2022

I don't think that using a different line style for specific segments of real rays is not going to prevent confusion. It didn't help me undertand this. What did help was @ariel-phet describing it to me, particularly the bit about thinking of the optic as extended infinitely.

So I think a better approach is to:

  • use the same line style for all real ray segments
  • provide teacher tips and other scaffolding to discuss Principal rays
  • modify the vertical axis to help support the "infinite optic" concept

I did a quick prototype, showed it to @arouinfar and @ariel-phet, refined it and pushed in the above commit. Screenshot shown below.

screenshot_1517

@pixelzoom
Copy link
Contributor

So to summarize, the proposal for addressing this issue is:

  • Provide teacher tips and other resources related to Principal rays.
  • Modify the look of the vertical axis to support those resources.

@arouinfar please review.

@pixelzoom pixelzoom changed the title Principal rays that don't pass through lens should be dashed How to address confusion related to Principal rays Jan 14, 2022
@pixelzoom pixelzoom changed the title How to address confusion related to Principal rays Address confusion related to Principal rays Jan 14, 2022
@arouinfar arouinfar mentioned this issue Jan 18, 2022
16 tasks
@arouinfar
Copy link
Contributor

I completely agree. Thanks for summarizing @pixelzoom. I've also added this issue to the Teacher Tips issue.

The vertical axis in #140 (comment) looks like an extension of the lens, and I'm happy with that look.

Things look a bit off in master (vertical axis only extends below optical axis), however, so back to @pixelzoom to investigate.

@pixelzoom
Copy link
Contributor

@arouinfar said

Things look a bit off in master (vertical axis only extends below optical axis), however, so back to @pixelzoom to investigate.

Handling that problem in #298, so closing this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants