-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Address confusion related to Principal rays #140
Comments
To clarify, only the portion of the ray that extends beyond vertical optic line (but without passing through the optic) should be dashed. In the case of the mirror, the "reflected" ray should be dashed if the ray does not go hit the mirror. |
Note that this will influence how #125 is addressed: |
@arouinfar Does this need to be addressed, or should it be closed? |
Discussed with @arouinfar on Zoom, yes we want to do this. |
I wasn't totally clear on what is desired here, so I discussed with @arouinfar on Zoom. Several of the comments above referred to "dotted" lines. Dashed lines are desired, not dotted. I've edited the comments to prevent confusion. The screenshots below show the scenarios that we need to handle. The red arrows point to the ray segments that should be dashed. Convex Lens + Real ImageConvex Lens + Virtual ImageConcave Lens + Virtual ImageConcave Mirror + Real ImageConcave Mirror + Virtual ImageConvex Mirror + Virtual Image |
@arouinfar proposed that virtual rays would look nicer using dashed line style. I prototyped this, ran it past @arouinfar, and she liked it. So it's implemented in the above commit. The screenshot below shows an example. This makes it problematic to use a dashed line style for some of the real ray segments. I have some other ideas for how to address that, which I'll work on next. |
I don't think that using a different line style for specific segments of real rays is not going to prevent confusion. It didn't help me undertand this. What did help was @ariel-phet describing it to me, particularly the bit about thinking of the optic as extended infinitely. So I think a better approach is to:
I did a quick prototype, showed it to @arouinfar and @ariel-phet, refined it and pushed in the above commit. Screenshot shown below. |
So to summarize, the proposal for addressing this issue is:
@arouinfar please review. |
I completely agree. Thanks for summarizing @pixelzoom. I've also added this issue to the Teacher Tips issue. The vertical axis in #140 (comment) looks like an extension of the lens, and I'm happy with that look. Things look a bit off in master (vertical axis only extends below optical axis), however, so back to @pixelzoom to investigate. |
@arouinfar said
Handling that problem in #298, so closing this issue. |
Some students were confused when comparing Many Rays to Principal Rays because in Many Rays, rays that don't pass through the optic are straight, but in Principal Rays, rays that don't pass through the optic are still reflected/refracted.
![image](https://user-images.githubusercontent.com/29347882/127383807-2822fdd2-fbf0-44d8-b925-7f0a36c17462.png)
![image](https://user-images.githubusercontent.com/29347882/127383771-b2bb0b6a-8f5d-4dfb-9fe4-8ea0221fa4fe.png)
The top and bottom principal rays should be dashed lines to emphasize that they do not represent real light rays like the ones in Many Rays.
The text was updated successfully, but these errors were encountered: