Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Odd looking Principal Rays #93

Closed
KatieWoe opened this issue Jul 8, 2021 · 3 comments
Closed

Odd looking Principal Rays #93

KatieWoe opened this issue Jul 8, 2021 · 3 comments

Comments

@KatieWoe
Copy link

KatieWoe commented Jul 8, 2021

Test device
Dell
Operating System
Win 10
Browser
Chrome
Problem description
For phetsims/qa#667. Mostly an odd visual behavior. It is, however, correct from a physics stand point, so I don't think it is a bug, but a second design pass may be desired. Specifically, the rays passing through the middle of the screen and bending or reflecting, even when the lens or mirror isn't there.
Steps to reproduce

  1. Go to either screen with any type of mirror
  2. Turn on Principal Rays
  3. Drag the object up above the lens or mirror

Visuals
alsooutside
rayoutsidelens

Troubleshooting information:

!!!!! DO NOT EDIT !!!!!
Name: ‪Geometric Optics‬
URL: https://phet-dev.colorado.edu/html/geometric-optics/1.0.0-dev.1/phet/geometric-optics_en_phet.html
Version: 1.0.0-dev.1 2021-07-08 19:47:13 UTC
Features missing: applicationcache, applicationcache, touch
Flags: pixelRatioScaling
User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/91.0.4472.124 Safari/537.36
Language: en-US
Window: 1280x657
Pixel Ratio: 1.5/1
WebGL: WebGL 1.0 (OpenGL ES 2.0 Chromium)
GLSL: WebGL GLSL ES 1.0 (OpenGL ES GLSL ES 1.0 Chromium)
Vendor: WebKit (WebKit WebGL)
Vertex: attribs: 16 varying: 30 uniform: 4096
Texture: size: 16384 imageUnits: 16 (vertex: 16, combined: 32)
Max viewport: 32767x32767
OES_texture_float: true
Dependencies JSON: {}

@veillette
Copy link
Contributor

We will bring it up at our next design meeting (7/13)

@veillette
Copy link
Contributor

We brought it up at the design meeting (7/13) . Assigning to @arouinfar to make design decision if needed.

@pixelzoom
Copy link
Contributor

9/30/21 design meeting:

This will be handled by implementing #140. So closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants